1353684 - nsIFileInputStream must return NS_ERROR_NOT_FOUND if Deserialize() fails.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

Currently, if a non-existing file is deserialized, we create a nsIFileInputStream with a null mFD. If we do a Read() on this file, we receive a NS_BASE_STREAM_CLOSED instead of NS_ERROR_FILE_NOT_FOUND.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: ipcBlob_2_fileInputStream.patch

Comment 2

[Andrea Marchesini [:baku]]

Attachment: ipcBlob_2_fileInputStream.patch

Comment 3

[Andrea Marchesini [:baku]]

Attachment: fileInputStream_NOT_FOUND.patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8859929 [details] [diff] [review]
fileInputStream_NOT_FOUND.patch

> nsFileInputStream::Init(nsIFile* aFile, int32_t aIOFlags, int32_t aPerm,
>                         int32_t aBehaviorFlags)
> {
>     NS_ENSURE_TRUE(!mFD, NS_ERROR_ALREADY_INITIALIZED);
>-    NS_ENSURE_TRUE(!mDeferredOpen, NS_ERROR_ALREADY_INITIALIZED);
>+    NS_ENSURE_TRUE(mState == eUnitialized || mState == eClosed,
>+                   NS_ERROR_ALREADY_INITIALIZED);
ok, this changes behavior of the edge case when there was an error, but I guess that is fine.

>+      // Something bad happen in the Open() or in Deserialize(). See
>+      // mErrorValue.
s/happen/happened/
"See mErrorValue" is rather odd comment when mErrorValue isn't document at all.
Perhaps you mean something like "The actual error value is stored in mErrorValue"-

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/daed4710bbf1
nsIFileInputStream must return NS_ERROR_NOT_FOUND if Deserialize() fails, r=smaug

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/daed4710bbf1