1353815 - Fixups in commitindex and conduitdemo docker-compose to get bugzilla integration working

Status: RESOLVED FIXED

(Conduit :: General, enhancement)

Comment 1

[Israel Madueme [:imadueme]]

Attachment: conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

Review commit: https://reviewboard.mozilla.org/r/126898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126898/

Comment 2

[Israel Madueme [:imadueme]]

Comment on attachment 8854980 [details]
conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126898/diff/1-2/

Comment 3

[Israel Madueme [:imadueme]]

Comment on attachment 8854980 [details]
conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126898/diff/2-3/

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8854980 [details]
conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

https://reviewboard.mozilla.org/r/126898/#review129682

::: commitindex/commitindex/reviews/triggers.py:36
(Diff revision 3)
>  
> -        commit['attachment_id'] = bugzilla.create_attachment(
> +        attachments.append(bugzilla.create_attachment(
>              1, commit_data, api_key=api_key
> -        )
> +        ))
>  
> -    return commits
> +    return attachments

From 'invoke lint':

-        attachments.append(bugzilla.create_attachment(
-            1, commit_data, api_key=api_key
-        ))
+        attachments.append(
+            bugzilla.create_attachment(1, commit_data, api_key=api_key)
+        )

Comments:
1. Should there only be one attachment per commit id in Bugzilla? So why not just add the attachment_id as before?

commit['attachment_id'] = bugzilla.create_attachment(
    1, commit_data, api_key=api_key
)

2. The caller of trigger_review() will get a list of attachments back without any mapping to their related commit id which is why I thought it would be best to include it in the commits[] list of dictionaries returned.

::: conduitdemo/docker-vct-hg/hgrc:10
(Diff revision 3)
>  reviewboard = /root/version-control-tools/hgext/reviewboard/client.py
>  conduit = /root/version-control-tools/hgext/conduit-client/client.py
>  
>  [bugzilla]
> -username = [e-mail]
> +username = [e-mail]
>  # Not a real api key

remove this comment as it is a real API key in the bmo container for the conduit user.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8854980 [details]
conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

https://reviewboard.mozilla.org/r/126898/#review129918

Fix issues post-landing. r=dkl

Comment 6

[Māris Fogels [:mars] (please needinfo)]

Comment on attachment 8854980 [details]
conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

https://reviewboard.mozilla.org/r/126898/#review129924

r+ for landing

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/automation/conduit/rev/546f6907f713
conduitdemo: fixups to get bugzilla integration to work . r=dkl,mars