1353917 - Update wizard fallback page fails the update when advancing to the downloading page after staging is done

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Molly Howell (she/her) (no longer active)]

Copied from bug 1316564 comment 55:

1) Starting from 53.0b8, update via the about window and close Firefox instead of clicking the restart button. This results in a partial update being successfully staged.
2) Overwrite the update.status file with "failed: 6".
3) Start the browser. Observe the "Update Failed" dialog, but don't click OK yet. The complete update downloads and stages while this window is showing.
4) Click OK, but only _after_ the update is downloaded and staged.
5) The progress window that appears next is broken; it hangs on "Connecting to the update server..."
6) Open the About window and click the restart button that is already showing there.
7) Observe that the update has not been applied.

The reason the update hasn't been applied is that step 4 causes the update.status file to be overwritten with "null". This is clearly a bug.

Comment 1

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1353917 - Skip the downloading page in the update wizard if the update is already staged.

The update wizard's fallback mode (where it appears on startup to download and
apply a complete update if applying a partial update has failed) begins to
download and stage the update without waiting for the user to confirm. This
means it can get ahead of itself and actually finish downloading and staging
before the user can click OK to bring up the progress page. The progress page
does not expect this and errors out in a way that breaks the otherwise valid
update. This change therefore skips over that page if the update is finished
staging when it would normally be shown.

Review commit: https://reviewboard.mozilla.org/r/126982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126982/

Comment 2

[Molly Howell (she/her) (no longer active)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4f1ef758e0f010fb06b46fb2b938e9aa85a7968

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8855076 [details]
Bug 1353917 - Skip the downloading page in the update wizard if the update is already staged.

https://reviewboard.mozilla.org/r/126982/#review129670

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/165a34ba15d9
Skip the downloading page in the update wizard if the update is already staged. r=rstrong

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/165a34ba15d9

Comment 6

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8855076 [details]
Bug 1353917 - Skip the downloading page in the update wizard if the update is already staged.

Approval Request Comment

[Feature/Bug causing the regression]:
Unknown; regression range doesn't show any apparently relevant changes.

[User impact if declined]:
This patch is a potential fix for bug 1316564, which is a high-ranking test failure on beta and ESR52. Per bug 1316564 comment 62, we would like to verify the fix (to the extent possible) on aurora and get it uplifted from there as soon as possible if it does work.

[Is this code covered by automated tests?]:
Yes

[Has the fix been verified in Nightly?]:
Not yet, just landed today

[Needs manual test from QE? If yes, steps to reproduce]: 
No

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
It's a minor and straightforward fix, and it's in UI that's not on any normal update path.

[String changes made/needed]:
None

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8855076 [details]
Bug 1353917 - Skip the downloading page in the update wizard if the update is already staged.

Fix an update issue. Aurora54+.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sadly the regression in bug 1355009 prevents us from verifying this fix. I will try to get this fixed ASAP.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/49b1ef6307a9

Comment 10

[Andrei Vaida [:avaida]]

(In reply to Matt Howell [:mhowell] from comment #6)
> [Is this code covered by automated tests?]:
> Yes
> [Needs manual test from QE? If yes, steps to reproduce]: 
> No

Setting qe-verify- based on Matt's assessment on manual testing needs and the fact that this fix has automated coverage.