1353992 - test_flexbox_focus_order.html fails on mac because mac focus is special

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Daniel Holbert [:dholbert]]

The new mochitest test_flexbox_focus_order.html (just added in bug 812687) is failing on Mac, because it's testing focus traversal order, and focus is a bit special on Mac.

We should fix this (by tweaking a pref in the test) but it'll take a little time to get the invocation exactly right.  It's not particularly concerning for the very short term, so I'm I'm marking the test as skipped on mac for now and I'll follow up with an actual fix on this bug.

Comment 1

[Daniel Holbert [:dholbert]]

This test (and a number of others) suggests that we need to set "accessibility.tabfocus" to 7, in order for tab to adjust focus across links on Mac:

> SimpleTest.waitForFocus(function () {
>   // Set the focus model so that links are focusable by the tab key even on Mac
>   SpecialPowers.pushPrefEnv({'set': [['accessibility.tabfocus', 7]]}, doTest);
https://dxr.mozilla.org/mozilla-central/rev/fdd53f7d454d15a0b0d82d6bdae2c4fed837d048/dom/html/test/test_object_plugin_nav.html#91-93

Try runs indicate that this does fix the test. I'll push that tweak to fix this bug.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f007bc728ec
Re-enable test_flexbox_focus_order.html on mac, with pref-tweak to allow links to be focused with 'tab' there. (no review, test-only)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f007bc728ec