1354041 - Avoid loading unneeded Telemetry JS modules in content process

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Georg Fritzsche [:gfritzsche]]

Per bug 1350472 we load Telemetry modules in the content process that are not actually needed:
- TelemetrySend.jsm
- ClientID.jsm

After any changes we should:
- build: mach build
- check eslint: mach eslint toolkit/components/telemetry
- run tests: mach test toolkit/components/telemetry/tests/unit

Comment 1

[Andrew McCreight [:mccr8]]

It looks like this would also avoid loading PromiseUtils.jsm and ServiceRequest.jsm at startup in content processes.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1354041 - Lazily load TelemetrySend in TelemetrySession.

This avoids loading it in content processes.

Review commit: https://reviewboard.mozilla.org/r/129104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129104/

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8857163 [details]
Bug 1354041 - Lazily load TelemetrySend in TelemetrySession.

https://reviewboard.mozilla.org/r/129104/#review131826

Comment 4

[Georg Fritzsche [:gfritzsche]]

Do we still load ClientID.jsm after this?
We should not need that module at all in content processes.
I'd be happy to take that to a separate bug though.

Comment 5

[Andrew McCreight [:mccr8]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #4)
> Do we still load ClientID.jsm after this?

We do not. Not loading TelemetrySend is sufficient to avoid loading it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86a7adbdc6ef
Lazily load TelemetrySend in TelemetrySession. r=gfritzsche

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/86a7adbdc6ef