1354137 - Awesome Screenshot shortcuts settings are not saved

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation.gif

[Affected versions]:
Firefox 55.0a1 (2017-04-05)
Firefox 54.0a2 (2017-04-05)
Firefox 53.0b9 (20170403072723)
Firefox 52.0.2 (20170323105023)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit

[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install the following add-on: https://addons.mozilla.org/en-US/firefox/addon/screenshot-capture-annotate/
3.Click on the webextension icon from toolbar and select “Options”.
4.Change the shortcuts settings.
5.Click “Save” button.
6.Reload the page.

[Expected Results]:
All the changes are successfully saved.


[Actual Results]:
Shortcuts changes are not saved and the default values are still displayed. 


[Additional notes]:
This issue reproduces only for 3.0.16 version of Awesome Screenshot webextension.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

I took a brief look at this issue and it looks like it have to be fixed in the extension itself,
in particular the "Image Format" is saved and restored as expected, while the "Shortcut Settings" are not
saved and stored correctly.

The following changes to the extension "options.js" source file has fixed the issue in my tests:

    diff -ur awesomescreenshot/javascripts/options.js awesomescreenshot-fix/javascripts/options.js
    --- awesomescreenshot/javascripts/options.js    2017-02-28 15:57:06.000000000 +0100
    +++ awesomescreenshot-fix/javascripts/options.js        2017-04-06 21:12:09.074303829 +0200
    @@ -121,7 +121,7 @@
            $('input:checkbox', $('#menu_shortcuts')).each(function() {
                    var id = this.id,
                            enable = this.checked,
    -                       key = $('select', $(this).parent().siblings('td.select')).attr('value');
    +                       key = $('select', $(this).parent().siblings('td.select')).val();

                    msObj[''+id] = {enable:enable, key:key};
            });
    @@ -129,7 +129,7 @@
            $('input:checkbox', $('#menu_features')).each(function() {
                    var id = this.id,
                            enable = this.checked,
    -                       key = $('select', $(this).parent().siblings('td.select')).attr('value');
    +                       key = $('select', $(this).parent().siblings('td.select')).val();

                    msObj[''+id] = {enable:enable, key:key};
            });
    @@ -182,7 +182,7 @@
                                    $el.attr({checked:'checked'});
                                    $pairingSelect.removeAttr('disabled');
                            }
    -                       $pairingSelect.attr({value:obj.key});
    +                       $pairingSelect.val(obj.key);
                    }
            }
     }

Comment 2

[Andreas Wagner [:TheOne] [use NI]]

The author has been notified.

Comment 3

[Andy McKay]

As a tracker this bug serves no purpose and the add-on is a webextension on AMO. The add-on developer was notified of this bug 7 months ago. Assuming they have fixed it and marking this as working.