Closed
Bug 1354221
Opened 7 years ago
Closed 7 years ago
Remove dead code in _process_rust_library
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: rillian, Unassigned)
Details
Attachments
(1 file)
recursivemake._process_rust_library() sets up `lib_var` and `feature_var` and then ignores them in favour of identical keys on the passed-in `libdef` object. It looks like this is dead code which can be removed.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8855422 [details] Bug 1354221 - Remove dead code in _process_rust_library. https://reviewboard.mozilla.org/r/127264/#review129994
Attachment #8855422 -
Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/583287ba13d0 Remove dead code in _process_rust_library. r=froydnj
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/583287ba13d0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•