1354670 - Give Focus and Klar a scheme

Status: RESOLVED FIXED

(Focus-iOS :: General, enhancement)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Give Focus and Klar a URL scheme. We don't have to handle incoming URLs yet. This is mainly to let Firefox detect is Focus or Klar is installed. Initial use case will be the MMA work being done in Firefox to promote Focus or Klar.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: https://github.com/mozilla-mobile/focus/pull/54

This adds unique URL schemes for Focus and Klar.

* `firefox-focus://`
* `firefox-klar://`

Comment 2

[:sdaswani]

Looks good to me - happy to r+.

Comment 3

[Bryan Munar (:bkmunar)]

Comment on attachment 8856060 [details] [review]
https://github.com/mozilla-mobile/focus/pull/54

yayz

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I added a little test app here:

  https://github.com/st3fan/FocusKlarSchemeTest

I only got this to work when I added the following to the Info.plist:

<key>LSApplicationQueriesSchemes</key>
<array>
  <string>firefox-klar</string>
  <string>firefox-focus</string>
</array>

Even when I was running this app from the Mozilla team. So you may have to add that to Firefox too.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Patch landed.

Comment 6

[:sdaswani]

(In reply to Stefan Arentz [:st3fan] from comment #1)
> Created attachment 8856060 [details] [review]
> https://github.com/mozilla-mobile/focus/pull/54
> 
> This adds unique URL schemes for Focus and Klar.
> 
> * `firefox-focus://`
> * `firefox-klar://`

LGTM