1355058 - Fix some minor perf issues in IonBuiler

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Handle TypedObjects last

getprop/getelem try the TypedObject case first, but this is a waste considering we're not even shipping typed objects in non-Nightly.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Don't add unused constraints in IonBuilder::typedObjectPrediction

I noticed we were adding some type constraints in IonBuilder::typedObjectPrediction. We can just reorder the checks so we only add the constraint if we actually have a typed object.

Comment 3

[Jan de Mooij [:jandem]]

At some point we should spend a few days profiling IonBuilder, I'm pretty sure there will be a lot of similar things.

Comment 4

[Hannes Verschore [:h4writer]]

Comment on attachment 8856478 [details] [diff] [review]
Part 1 - Handle TypedObjects last

Review of attachment 8856478 [details] [diff] [review]:
-----------------------------------------------------------------

I agree we should first do the cases that are happening the most. Good find.

Comment 5

[Hannes Verschore [:h4writer]]

Comment on attachment 8856479 [details] [diff] [review]
Part 2 - Don't add unused constraints in IonBuilder::typedObjectPrediction

Review of attachment 8856479 [details] [diff] [review]:
-----------------------------------------------------------------

Good find!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd4b315d43b9
part 1 - Try the TypedObject optimizations last as typed objects are disabled by default. r=h4writer
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad497a610771
part 2 - Avoid creating unnecessary type constraints in IonBuilder::typedObjectPrediction. r=h4writer

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fd4b315d43b9
https://hg.mozilla.org/mozilla-central/rev/ad497a610771