1355222 - Enable devicemanager debug logging from mach test commands

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, enhancement, P2)

Description

[Geoff Brown [:gbrown]]

When debugging problems in Android tests initiated from mach, the devicemanager logging can be very useful, but there's no easy way to enable it. Let's hook the mach --log-xxx-level options to devicemanager logging.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: enable devicemanager debug logging when debug mach logging requested

For example,

gbrown@mozpad:~/src$ ./mach reftest --log-tbpl-level=debug layout/reftests/reftest-sanity/reftest.list
mozdevice DEBUG | _runCmd - command: adb version
mozdevice DEBUG | Android Debug Bridge version 1.0.36
mozdevice DEBUG | Revision 0e9850346394-android
mozdevice INFO  | Detected adb 1.0.36
mozdevice DEBUG | _checkCmd - command: adb shell echo
mozdevice DEBUG | 
mozdevice DEBUG | _runCmd - command: adb shell getprop ro.build.version.sdk
mozdevice DEBUG | 18
mozdevice INFO  | Detected Android sdk 18
mozdevice DEBUG | _runCmd - command: adb shell id
mozdevice DEBUG | uid=0(root) gid=0(root) context=u:r:shell:s0
...

I'm hoping this might be helpful in cases such as bug 1354055.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8856716 [details] [diff] [review]
enable devicemanager debug logging when debug mach logging requested

Review of attachment 8856716 [details] [diff] [review]:
-----------------------------------------------------------------

nice!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6697d89d054
When debug logging requested for android mach test commands, enable devicemanager logging; r=jmaher

Comment 4

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/d6697d89d054