1355477 - add "view diff" button to Release Scheduled Changes UI

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P3)

Description

[[e-mail] (:bhearsum)]

When reviewing a scheduled change to a Release it would be helpful to be able to see what is changing vs the current version of the object. Without it, most blobs are too big to review in a useful way.

A diff, similar to what we do in the Releases History UI, is likely the best way to show this. It's only needed for change_type "update" (inserts are an entirely new blob, and deletes remove an entire blob).

This may need some backend support to generate the required diff.

Comment 1

[Aki Sasaki (not active)]

++

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

I submit it would be even better to show the change in the context of the other rules for the same product+channel.

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Nick Thomas [:nthomas] from comment #2)
> I submit it would be even better to show the change in the context of the
> other rules for the same product+channel.

I might be misunderstanding your comment, but I'm not sure how it fits here since this bug is about Releases? Bugs 1316948 and bug 1329524 might be more relevant, where we're talking about being able to query the state of things at a particular point in time.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Whoops, sorry about that.

Comment 5

[Rachael]

@bhearsum my understanding of this bug fix is to have a "diff" button that shows current vs previous data.
As suggested earlier the bug fix should have an implementation similar to the history ui but when i check at this ui i cannot see how it was implemented...Am i missing something.Please clarify..
if possible could we have a sync call for this?

Comment 6

[Rachael]

@bhearsum i managed to replicate the history ui.Finally understood how to implement it.thanks

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/6c22b974b95069127fee14697f7a7f80dc820f3b
bug 1355477: View Diff in Scheduled Release updates (#447). r=bhearsum

Comment 8

[[e-mail] (:bhearsum)]

Now in production, thanks Collins!

Comment 9

[Collins Abitekaniza]

(In reply to Ben Hearsum (:bhearsum) from comment #8)
> Now in production, thanks Collins!

You're welcome :)