1355696 - convert uses of "defer" to "new Promise" - client/sourceeditor

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect)

Description

[smfurqan]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170329150204

Comment 1

[smfurqan]

I have been going through the different files to locate the instances of "defer" that need to be updated but I'm a little confused on how I should convert them to "new promise". Could you provide some guidance please?

Comment 2

[Loic]

I'm just triager.

Comment 3

[Tom Tromey :tromey]

(In reply to smfurqan from comment #1)
> I have been going through the different files to locate the instances of
> "defer" that need to be updated but I'm a little confused on how I should
> convert them to "new promise". Could you provide some guidance please?

I think this message shows the ordinary approach:
https://groups.google.com/forum/#!msg/mozilla.dev.developer-tools/IYw2U4TCNYU/JwfhnfomAwAJ

It's possible there could be cases that can't be handled this way.
If you run across one of those we can discuss it here or on irc.

Comment 4

[Matt R [:stylizit] (slow, away until Sep)]

Attachment: Bug 1355696 - convert uses of 'defer' to 'new Promise' in client/sourceeditor;

Review commit: https://reviewboard.mozilla.org/r/141332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141332/

Comment 5

[Tom Tromey :tromey]

Comment on attachment 8869803 [details]
Bug 1355696 - convert uses of 'defer' to 'new Promise' in client/sourceeditor;

https://reviewboard.mozilla.org/r/141332/#review145262

Thanks for the patch.  This looks good to me.  I'll send it through try now.

Comment 6

[Matt R [:stylizit] (slow, away until Sep)]

(In reply to Tom Tromey :tromey from comment #5)
> Thanks for the patch.  This looks good to me.  I'll send it through try now.

Thanks for the review! Try results seem to show intermittent failures and Webcrypto. Those seem unrelated to me, so we should be good to go?

P.S: Sorry to flood you with so many review reqs

Comment 7

[Tom Tromey :tromey]

(In reply to Matt R :stylizit from comment #6)
> (In reply to Tom Tromey :tromey from comment #5)
> > Thanks for the patch.  This looks good to me.  I'll send it through try now.
> 
> Thanks for the review! Try results seem to show intermittent failures and
> Webcrypto. Those seem unrelated to me, so we should be good to go?

Yep.  Going to land it now.  Thanks again for the patch.

> P.S: Sorry to flood you with so many review reqs

It's the sort of problem that's good to have :)
It may take me another day to review them due to my schedule here,
but I will make some progress today at least.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fde169875b3
convert uses of 'defer' to 'new Promise' in client/sourceeditor; r=tromey

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2fde169875b3