1356023 - Remove nsIScreenManager.systemDefaultScale

Status: RESOLVED FIXED

(Core :: Widget, enhancement)

Description

[Masatoshi Kimura [:emk]]

This property is very inconsistent between platforms. On macOS and mobile, it will always return 1.0. It will take into account DefaultScaleOverride() on Linux while it does not on Windows.

This property was added for ease of migration (see bug 851520). But it was not used when Gtk widget supported high DPI.

I think this property will only confuse people now.

Comment 1

[Masatoshi Kimura [:emk]]

Some default-zoom-tweaking addons will be affected.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1356023 - Remove nsIScreenManager.systemDefaultScale.

Review commit: https://reviewboard.mozilla.org/r/129626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129626/

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8857884 [details]
Bug 1356023 - Remove nsIScreenManager.systemDefaultScale.

https://reviewboard.mozilla.org/r/129626/#review132924

Yes, I think we can consider this obsolete and get rid of it.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2758e4140ece -d 9e9398d512bd: rebasing 389971:2758e4140ece "Bug 1356023 - Remove nsIScreenManager.systemDefaultScale. r=jfkthame" (tip)
merging browser/components/nsBrowserGlue.js
merging widget/PuppetWidget.cpp
warning: conflicts while merging browser/components/nsBrowserGlue.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8857884 [details]
Bug 1356023 - Remove nsIScreenManager.systemDefaultScale.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129626/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ad613f8801a
Remove nsIScreenManager.systemDefaultScale. r=jfkthame

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9ad613f8801a