Closed
Bug 1356249
Opened 7 years ago
Closed 7 years ago
Crash in profiler_set_frame_number
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | fixed |
People
(Reporter: calixte, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
(Keywords: crash, Whiteboard: [clouseau])
Crash Data
Attachments
(1 file)
|
955 bytes,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-06b7d81b-708a-4649-a28b-4c72b2170412. ============================================================= There are 18 crashes coming from 1 installation in nightly 55 with buildid 20170412030252. :njn, I don't know if it's related to your recent modifications in this part of the code, but maybe...
Flags: needinfo?(n.nethercote)
|
Assignee | |
Comment 1•7 years ago
|
||
The assertion is probably just wrong. I will take a look early next week.
Assignee: nobody → n.nethercote
Flags: needinfo?(n.nethercote)
|
Reporter | |
Comment 2•7 years ago
|
||
In report [1], the user added this comment:
"enabled user_pref("layers.frame-counter", true); wanted to see what it is doing. crashing permarnently. have to remove it manually from prefs.js"
[1] https://crash-stats.mozilla.com/report/index/e3de443d-5d57-4d79-bec9-d0cdb2170417|
|
Assignee | |
Comment 3•7 years ago
|
||
This function can run off the main thread when 'layers.frame-counter' is enabled.
Attachment #8859011 -
Flags: review?(mstange)
|
||
Updated•7 years ago
|
Attachment #8859011 -
Flags: review?(mstange) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bbf24f5eb3b Fix assertion in profiler_set_frame_number(). r=mstange.
|
|
Assignee | |
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bbf24f5eb3bb3e5313db5dd64b0aa2d426675f1 Bug 1356249 - Fix assertion in profiler_set_frame_number(). r=mstange.
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9bbf24f5eb3b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•7 years ago
|
Blocks: 1342306
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•