1356275 - stylo: heap write analysis failure on known-unsafe Gecko_GetFontMetrics

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Steve Fink [:sfink] [:s:]]

bholley suggests: "We should just MOZ_ASSERT(NS_IsMainThread()) in this function until further notice."

Comment 1

[Manish Goregaokar [:manishearth]]

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a5b4722e254d3a1a53b1caa8ec9b5c7cf7950be

Comment 2

[Manish Goregaokar [:manishearth]]

Er, wrong bug

Comment 3

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1356275 - Assert that we're on the main thread in the unused and unsafe Gecko_GetFontMetrics ;

Review commit: https://reviewboard.mozilla.org/r/130140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130140/

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8858195 [details]
Bug 1356275 - Assert that we're on the main thread in the unused and unsafe Gecko_GetFontMetrics ;

https://reviewboard.mozilla.org/r/130140/#review134966

Sorry this got lost somehow, I only noticed on the review whine. Feel free to ping me for mechanical stuff like this.

Comment 5

[Manish Goregaokar [:manishearth]]

Comment on attachment 8858195 [details]
Bug 1356275 - Assert that we're on the main thread in the unused and unsafe Gecko_GetFontMetrics ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130140/diff/1-2/

Comment 6

[Manish Goregaokar [:manishearth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bf07038e0e66c473a9f68883d07b1e869b92480

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c187a205fc6
Assert that we're on the main thread in the unused and unsafe Gecko_GetFontMetrics ; r=bholley

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ad23bc8d5c1
Decrease allowed write hazard threshhold; r=bholley

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9c187a205fc6
https://hg.mozilla.org/mozilla-central/rev/4ad23bc8d5c1