1356322 - [eslint] Reduce the cyclomatic complexity in browser/components

Status: NEW

(Firefox :: General, enhancement)

Description

[Jim Porter (:squib)]

Currently, we set the max cyclomatic complexity for browser/components/* to be 70 because of BG__migrateUI. We should just make an exception for this function rather than the entire subdirectory.

Comment 1

[Jim Porter (:squib)]

Attachment: Bug 1356322 - [eslint] Reduce the cyclomatic complexity in browser/components/

Review commit: https://reviewboard.mozilla.org/r/130868/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130868/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8858880 [details]
Bug 1356322 - [eslint] Reduce the cyclomatic complexity in browser/components/

https://reviewboard.mozilla.org/r/130868/#review133496

This is fine with me but please run this by Standard8 so that he knows about this change in direction.

::: commit-message-05c21:1
(Diff revision 1)
> +Bug 1356322 - [eslint] Reduce the cyclomatic complexity in browser/components  r?jaws

This comment is a little too broad. It is reducing it but it's not explaining why or how. This needs to be more specific before this patch lands. See https://groups.google.com/forum/#!topic/mozilla.dev.platform/qERnoJniCds

Comment 3

[Jim Porter (:squib)]

Comment on attachment 8858880 [details]
Bug 1356322 - [eslint] Reduce the cyclomatic complexity in browser/components/

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130868/diff/1-2/

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8858880 [details]
Bug 1356322 - [eslint] Reduce the cyclomatic complexity in browser/components/

https://reviewboard.mozilla.org/r/130868/#review133912

::: commit-message-05c21:1
(Diff revision 2)
> +Bug 1356322 - [eslint] Reduce the cyclomatic complexity in browser/components/  r?jaws

I would change this slightly to "Reduce the maximum allowed cyclomatic..."

::: browser/components/nsBrowserGlue.js:205
(Diff revision 2)
>      Cu.import("resource://services-sync/main.js");
>      Weave.Service.scheduler.delayedAutoConnect(delay);
>    },
>  
>    // nsIObserver implementation
> +  // eslint-disable-next-line complexity

Please can you file bugs for these 4 disabling, so that we can get a recorded discussion/decision as to if we are going to work to reduce the complexity of them or not.

Bonus points for adding bug references in the comments.

Comment 5

[Jim Porter (:squib)]

Comment on attachment 8858880 [details]
Bug 1356322 - [eslint] Reduce the cyclomatic complexity in browser/components/

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130868/diff/2-3/

Comment 6

[Dão Gottwald [:dao]]

I wasted precious time on this again in bug 1363118.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.