Closed
Bug 135634
Opened 22 years ago
Closed 2 years ago
Implement support for XSolarisGetVisualGamma()
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
WONTFIX
mozilla1.0
People
(Reporter: roland.mainz, Unassigned)
References
Details
Attachments
(1 file)
[Looking at bug 53597 ("CSS colors are missing gamma correction") I noticed that we do not implement support for XSolarisGetVisualGamma() - therefore:] RFE: Implemement support for XSolarisGetVisualGamma()
Reporter | ||
Comment 1•22 years ago
|
||
Taking myself...
Reporter | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•22 years ago
|
||
Comment 4•22 years ago
|
||
r=cls on the Makefile changes
Comment 5•22 years ago
|
||
you'll want to remove XSolarisGetVisualGamma from the comment that states that it should be used
Comment 6•22 years ago
|
||
And: maybe you should add this code also to Qt However, couldn't this be put into x11shared/ directory so only 1 file needs to be changed if a new way for getting Gamma values is added?
Reporter | ||
Comment 7•22 years ago
|
||
Christian Biesinger wrote: > you'll want to remove XSolarisGetVisualGamma from the comment that states that > it should be used OK, I can do that at checkin time or when the (super-)reviewer wants a new patch... ---- > And: maybe you should add this code also to Qt Qt is another, bigger problem. Currently it is completly broken... and IMHO the Qt API should provide a method to do this - we should not call the Solaris-specific API directly... > However, couldn't this be put into x11shared/ directory so only 1 file needs > to be changed if a new way for getting Gamma values is added? Not really, the code is too small. I still hope that we get (someday) an unified gfx code... ;-(
Comment 8•22 years ago
|
||
>IMHO the
>Qt API should provide a method to do this - we should not call the
>Solaris-specific API directly...
well, Gtk should, too, but apparently it doesn't :)
and yes, I know it doesn't compile, but this is an easy change, esp. if you
leave the PR_LOG stuff out. anyway, do it or not, I don't really care.
Solaris is no longer officially supported
Should this therefore be closed?
Comment 10•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:enndeakin, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee: roland.mainz → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(enndeakin)
Updated•2 years ago
|
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(enndeakin)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•