1356457 - Intermittent test_ext_proxy.html | message queue is empty - got "[\"proxy-error-received\"]", expected "[]"

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=91506454&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/GCjNyHusRNOSKyg_-1w7-g/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

16 failures in 894 pushes (0.018 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 7
* mozilla-inbound: 6
* mozilla-central: 3

Platform breakdown:
* linux32: 12
* windows7-32-vm: 2
* windows8-64: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356457&startday=2017-04-10&endday=2017-04-16&tree=all

Comment 2

[Geoff Brown [:gbrown]]

:mattw - Do you want to take another look at this? It seems the previous fix was ineffective.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

in the last week has have 50 failures, so this is getting to be a bit more painful

Comment 4

[Intermittent Failures Robot]

15 failures in 162 pushes (0.093 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 7
* mozilla-inbound: 5
* graphics: 3

Platform breakdown:
* linux32: 13
* osx-10-10: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356457&startday=2017-04-21&endday=2017-04-21&tree=all

Comment 5

[Intermittent Failures Robot]

63 failures in 817 pushes (0.077 failures/push) were associated with this bug in the last 7 days. 

This is the #9 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 25
* mozilla-inbound: 24
* try: 5
* mozilla-central: 5
* graphics: 4

Platform breakdown:
* linux32: 44
* linux64: 8
* windows7-32-vm: 7
* windows8-64: 2
* osx-10-10: 1
* android-4-3-armv7-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356457&startday=2017-04-17&endday=2017-04-23&tree=all

Comment 6

[Geoff Brown [:gbrown]]

Attachment: disable test

This test was added in bug 1295807 and started failing intermittently right away - reported initially in bug 1345491, where a fix was attempted - so we are coming up on 8 weeks of flakiness. Hopefully Matt can sort out the issue in the future and get this re-enabled.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8862860 [details] [diff] [review]
disable test

Review of attachment 8862860 [details] [diff] [review]:
-----------------------------------------------------------------

make sure to add leave-open here

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb4dfb493bbb
Skip test_ext_proxy.html for frequent failures; r=jmaher

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fb4dfb493bbb

Comment 10

[Intermittent Failures Robot]

31 failures in 883 pushes (0.035 failures/push) were associated with this bug in the last 7 days. 

This is the #38 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 20
* mozilla-inbound: 6
* graphics: 2
* try: 1
* oak: 1
* mozilla-central: 1

Platform breakdown:
* linux32: 16
* linux64: 11
* windows7-32-vm: 2
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356457&startday=2017-04-24&endday=2017-04-30&tree=all

Comment 11

[Matthew Wein [:mattw]]

I was able to reproduce the intermittent locally and will now try to find a fix.

Comment 12

[Matthew Wein [:mattw]]

Attachment: Bug 1356457 - Fix and enable test_ext_proxy.html

I was able to fix the issue by only letting the background script send one error message per test. This isn't an ideal fix because it doesn't get to the bottom of why a second error message is sometimes sent, but it should be a good placeholder while the underlying issue is researched.

Review commit: https://reviewboard.mozilla.org/r/135136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135136/

Comment 13

[Matthew Wein [:mattw]]

Comment on attachment 8863377 [details]
Bug 1356457 - Fix and enable test_ext_proxy.html

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135136/diff/1-2/

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8863377 [details]
Bug 1356457 - Fix and enable test_ext_proxy.html

https://reviewboard.mozilla.org/r/135136/#review138088

this looks good, as a note, this test is skipped, so we need to edit the manifest to not skip it:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/test/mochitest/mochitest-common.ini#78

Comment 15

[Matthew Wein [:mattw]]

Comment on attachment 8863377 [details]
Bug 1356457 - Fix and enable test_ext_proxy.html

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135136/diff/2-3/

Comment 16

[Matthew Wein [:mattw]]

Thanks

Comment 17

[Tomislav Jovanovic :zombie]

This could be caused by fetching of the "favicon.ico" when you open a tab.  You should be able to confirm it by dump()ing the url from the FindProxyForURL() function.  If that's indeed the case, then this solution (or just removing the listener after the first error) should be fine.

Comment 18

[Tomislav Jovanovic :zombie]

Sorry for the keywords, that was by accident.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ef61ecb82e2
Fix and enable test_ext_proxy.html r=jmaher

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ef61ecb82e2

Comment 21

[Matthew Wein [:mattw]]

needinfo'ing myself to look into comment 18.

Comment 22

[Matthew Wein [:mattw]]

sorry, I mean comment 17

Comment 23

[Bob Silverberg [:bsilverberg]]

Removing the [stockwell disabled] tag because the test that this bug references no longer exists. I changed it to [stockwell unknown] rather than just removing the tag entirely to maintain a record.