1356514 - Remove the usage of nsContentUtils::IsInPrivateBrowsing() in HTMLMediaElement.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[(no longer active)]

Follow-up to bug 1194891.

We need to switch this code to pass in the private browsing ID instead.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Blake, this looks at your wheelhouse.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1356514 - remove the usage of nsContentUtils::IsInPrivateBrowsing() in HTMLMediaElement.cpp.

Per bug 1194891 comment 35, use |NodePrincipal()->GetPrivateBrowsingId() > 0| instead.

Review commit: https://reviewboard.mozilla.org/r/131052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131052/

Comment 3

[(no longer active)]

Comment on attachment 8859033 [details]
Bug 1356514 - remove the usage of nsContentUtils::IsInPrivateBrowsing() in HTMLMediaElement.cpp.

https://reviewboard.mozilla.org/r/131052/#review135390

Thanks!

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68798c23a30d
remove the usage of nsContentUtils::IsInPrivateBrowsing() in HTMLMediaElement.cpp. r=Ehsan

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/68798c23a30d