1356537 - Revert the device reset check in EndFrame

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Kevin Chen[:kechen] (UTC + 8)]

The device reset check in EndFrame was to prevent the program from crashes caused by swapchain->present; however, we already have another check in BeginFrame which might be enough and also it causes some performance issues in Bug 1355416. Therefore, it might be advisable to remove the check here.

I will keep monitoring if there are any new crashes after this change.

[1] https://dxr.mozilla.org/mozilla-central/rev/f40e24f40b4c4556944c762d4764eace261297f5/gfx/layers/d3d11/CompositorD3D11.cpp#1433

Comment 1

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Bug 1356537 - Revert device reset check in EndFrame;

Review commit: https://reviewboard.mozilla.org/r/130248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130248/

Comment 2

[Kevin Chen[:kechen] (UTC + 8)]

Comment on attachment 8858265 [details]
Bug 1356537 - Revert device reset check in EndFrame;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130248/diff/1-2/

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8858265 [details]
Bug 1356537 - Revert device reset check in EndFrame;

https://reviewboard.mozilla.org/r/130248/#review134664

Sounds good, we should keep an eye to see if the original bug this check fixed re-appears. If so we can relegate it to the GPU process.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5f7c3e9f1b9
Revert device reset check in EndFrame; r=dvander

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5f7c3e9f1b9