1356575 - WARNING: Cannot set transparency mode on top-level windows.: file c:/mozilla-source/comm-central/mozilla/widget/windows/nsWindow.cpp, line 3057

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[ISHIKAWA, Chiaki]

Starting early April (meaning that the change in the source code must have happened before that, possibly in March), I get the following warning many times
during the execution of |make mozmill| test suite run of FULL DEBUG version of C-C TB locally.

From my local summary:
without NS_ENSURE macros:

Count/sum is modulo [without the first PID]

=>27571 [1101] WARNING: Cannot set transparency mode on non-popup windows.: file /NREF-COMM-CENTRAL/comm-central/mozilla/widget/gtk/nsWindow.cpp, line 4308
   8526 [1101] WARNING: 'NS_FAILED(rv)', file /NREF-COMM-CENTRAL/comm-central/mozilla/caps/BasePrincipal.cpp, line 380
   1019 [1361] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /NREF-COMM-CENTRAL/comm-central/mozilla/parser/html/nsHtml5StreamParser.cpp, line 985
    345 [1101] WARNING: No inner window available!: file /NREF-COMM-CENTRAL/comm-central/mozilla/dom/base/nsGlobalWindow.cpp, line 10330
    140 [24161] WARNING: We should have hit the document element...: file /NREF-COMM-CENTRAL/comm-central/mozilla/layout/xul/BoxObject.cpp, line 174
     Second without NS_ENSURE macros:
    ...

We get the warning
WARNING: Cannot set transparency mode on non-popup windows.: file /NREF-COMM-CENTRAL/comm-central/mozilla/widget/gtk/nsWindow.cpp, line 4308

27571 times, quite many, during |make mozmill|.

This is wasting CPU cycles.

TIA

PS: I am still struggling to set up my new PC in my spare time.

Comment 1

[Jorg K (CEST = GMT+2)]

Yes, I see an awful lot of those on Windows, too:

[2896] WARNING: Cannot set transparency mode on top-level windows.: file c:/mozilla-source/comm-central/mozilla/widget/windows/nsWindow.cpp, line 3057

They're quite spammy :-(

Mason, can this be turned down a bit, if makes for a felt 80% of the console output.

Comment 2

[Timothy Nikkel (:tnikkel)]

Dupe of bug 1354619?

Comment 3

[Jorg K (CEST = GMT+2)]

Yes, in principal that was fixed by bug 1354619, sadly for Linux only. I'm still seeing it on Windows as per my comment #1:

WARNING: Cannot set transparency mode on top-level windows.: file c:/mozilla-source/comm-central/mozilla/widget/windows/nsWindow.cpp, line 3057

Coming from ... /windows/nsWindow.cpp, line 3057.

Slightly different warning, but equally spammy, so let's recycle this bug for Windows, OK?

Comment 4

[Lee Salzman [:lsalzman]]

(In reply to Jorg K (GMT+2) from comment #3)
> Yes, in principal that was fixed by bug 1354619, sadly for Linux only. I'm
> still seeing it on Windows as per my comment #1:
> 
> WARNING: Cannot set transparency mode on top-level windows.: file
> c:/mozilla-source/comm-central/mozilla/widget/windows/nsWindow.cpp, line 3057
> 
> Coming from ... /windows/nsWindow.cpp, line 3057.
> 
> Slightly different warning, but equally spammy, so let's recycle this bug
> for Windows, OK?

As noted in bug 1354619, this was fixed for all platforms, but only on platforms for which there was no actual change in transparency mode. So if this is still triggering on another platform, then that means there is an actual bug there.

Forwarding this one to Mike Conley, since he added the warning...

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1356575 - Don't warn on SetTransparencyMode on Windows if the mode isn't actually changing.

Review commit: https://reviewboard.mozilla.org/r/131310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131310/

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 8859297 [details]
Bug 1356575 - Don't warn on SetTransparencyMode on Windows if the mode isn't actually changing.

https://reviewboard.mozilla.org/r/131310/#review133952

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad759c77da08
Don't warn on SetTransparencyMode on Windows if the mode isn't actually changing. r=jimm

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad759c77da08

Comment 10

[Mike Conley (:mconley) (:⚙️)]

ni?ing myself to request uplift to beta.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Has this improved in the latest Nightly?

Comment 12

[Jorg K (CEST = GMT+2)]

Yes, thank you. Chiaki originally raised this bug for Linux, but since that got fixed in bug 1354619, I hijacked the bug for Windows, see comment #3. All is well now.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8859297 [details]
Bug 1356575 - Don't warn on SetTransparencyMode on Windows if the mode isn't actually changing.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1344839, so 54+
[User impact if declined]: Excessive warning spam on Windows.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: This does not change the semantics of the underlying code at all, and just silences a spammy warning on Windows.
[String changes made/needed]: none

Comment 14

[Gerry Chang [:gchang]]

Comment on attachment 8859297 [details]
Bug 1356575 - Don't warn on SetTransparencyMode on Windows if the mode isn't actually changing.

Fix an issue that generates excessive warning spam on Windows. Beta54+. Should be in 54 beta 2.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/713a6c2a6b15

Comment 16

[Andrei Vaida [:avaida]]

(In reply to Mike Conley (:mconley) from comment #13)
> [Is this code covered by automated tests?]: yes
> [Needs manual test from QE? If yes, steps to reproduce]: no 

Setting qe-verify- based on Mike's assessment on manual testing needs and the fact that this fix has automated coverage.