Closed
Bug 1356691
Opened 7 years ago
Closed 7 years ago
Make DeadObjectProxies preserve IsCallable and IsConstructor statically instead of an extra slot
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | wontfix |
firefox55 | --- | fixed |
People
(Reporter: shu, Assigned: shu)
References
Details
Attachments
(1 file, 1 obsolete file)
Spun off from bug 1354294.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8858423 -
Flags: review?(wmccloskey)
Comment 2•7 years ago
|
||
Thanks :)
Assignee: nobody → shu
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → affected
status-firefox55:
--- → affected
status-firefox-esr52:
--- → unaffected
Attachment #8858423 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Hmm, this is causing a RecomputeWrappers assertion in try here: https://treeherder.mozilla.org/logviewer.html#?job_id=91779950&repo=try&lineNumber=2690
Assignee | ||
Updated•7 years ago
|
Summary: Make DeadObjectProxies always IsCallable and IsConstructor instead preserving the old targets' values → Make DeadObjectProxies preserve IsCallable and IsConstructor statically instead of an extra slot
Assignee | ||
Comment 4•7 years ago
|
||
Decided to not investigate test failure from comment 3 and still preserve IsCallable and IsConstructor, just via templates this time.
Attachment #8858998 -
Flags: review?(wmccloskey)
Assignee | ||
Updated•7 years ago
|
Attachment #8858423 -
Attachment is obsolete: true
Attachment #8858998 -
Flags: review?(wmccloskey) → review+
Pushed by shu@rfrn.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/67bf37b2c974 Preserve DeadObjectProxy's IsCallable and IsConstructor values statically with templates. (r=billm)
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/67bf37b2c974
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 7•7 years ago
|
||
Mark 54 won't fix as this is late for Beta54.
You need to log in
before you can comment on or make changes to this bug.
Description
•