1357322 - Remove media/webrtc/trunk/webrtc/modules/audio_device/gonk

Status: RESOLVED WORKSFORME

(Core :: WebRTC, enhancement, P3)

Description

[Mike Hommey [:glandium]]

As per bug 1355752 comment 25, gonk widget support can go away now.

Comment 1

[Dan Minor [:dminor]]

Attachment: Remove gonk audio device

Can probably just import this into the patch queue for the branch 57 update.

Comment 2

[Mike Hommey [:glandium]]

There are gyp files that reference those.

Comment 3

[Dan Minor [:dminor]]

(In reply to Mike Hommey [:glandium] (VAC: Apr 20-May 4) from comment #2)
> There are gyp files that reference those.

Thanks! It built ok, but I should have searched for references to the files anyway.

Comment 4

[Dan Minor [:dminor]]

Hmm, the only references to "audio_manager.cc" I'm seeing are to android/audio_manager.cc, which presumably we want to keep.

I filed Bug 1357368 to handle removing the rest of the references to gonk from the webrtc code base. I'm guessing :jesup would prefer to wait until after the branch 57 update lands before we clean that stuff up, rather than having to do a rebase.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8859142 [details] [diff] [review]
Remove gonk audio device

Review of attachment 8859142 [details] [diff] [review]:
-----------------------------------------------------------------

Yes = making it clear I'm holding off until the v57 update lands later this week, probably

Comment 6

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 7

[Dan Minor [:dminor]]

Looks like all references are now gone.