1357392 - Update webrender to f3fa3481aac63ac93c6ccbe805379875e24e5b77.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1355475 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ f687ff6c3df63a6846f7f96c71c4d76b34f7198e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06d60340deb975a1a1fa99d88fbff0647857da9b

Orange across the board. The last good rev is 07b6c6a1f93b5d8af1dd9ae825906dcf5c310810, so the regression range is:

*   f687ff6 Auto merge of #1123 - Gankro:profipc, r=kvark
|\
| * cb0bc28 Add profiling for IPC overhead
|/
* 1c59cd6 Auto merge of #1127 - MortimerGoro:get_shader_precision, r=kvark
* 112af22 Implement GetShaderPrecisionFormat WebGL command

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 1c59cd6 is green [1]. Therefore the regression is coming from cb0bc28.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=07b45d900179fb06726dd50860793a214d23bbba

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Gankro provided me with the fixes for the failures - we needed to regenerate the FFI header and update the IPC code for the new fields. With that the try push is green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b121d22a69f28ae9a64d674cb4de082302ad3ce2

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ dc0e7487d54377aadd43678b3ad6e2aade2d2e71

https://treeherder.mozilla.org/#/jobs?repo=try&revision=31f793d45c07b32754c10538d97ffb5790ff229c

Green with compile fixes.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 04eeee4593c11a0d9c934722896c67aa5ddd9554

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45fd6334cd03349c9bb63be349a480a975efc807

Bustage from add_raw_font changes. Looks like I need to add some zeros.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ 04eeee4593c11a0d9c934722896c67aa5ddd9554 with the aforementioned zeros.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a63e259c67753b15ec7fb61836e2f7fa68db5ded

Green

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ ec954b8dc3e1338d31acc306bd5bcd4f897c4864

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5926c2d68c8049daf56d2433c2a2f88a5e3ebf6f

Green

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ f3fa3481aac63ac93c6ccbe805379875e24e5b77

https://treeherder.mozilla.org/#/jobs?repo=try&revision=065dae9ca802537176f4c76de39d82f5ecba4495

Green

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1357392 - Update webrender to f3fa3481aac63ac93c6ccbe805379875e24e5b77.

Review commit: https://reviewboard.mozilla.org/r/132082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132082/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1357392 - Update Cargo.lock/Cargo.toml files and re-generate FFI header.

Review commit: https://reviewboard.mozilla.org/r/132084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132084/

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1357392 - Re-vendor third-party rust dependencies.

Review commit: https://reviewboard.mozilla.org/r/132086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132086/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1357392 - Update IPC code for new fields in struct added in cb0bc28.

Review commit: https://reviewboard.mozilla.org/r/132088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132088/

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1357392 - Update for removal of release callback function in 86d4255.

Review commit: https://reviewboard.mozilla.org/r/132090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132090/

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1357392 - Update callback functions for new parameter added in d733af2.

Review commit: https://reviewboard.mozilla.org/r/132092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132092/

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1357392 - Update calls to add_raw_font for API change in 21f2946.

Review commit: https://reviewboard.mozilla.org/r/132094/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132094/

Comment 16

[Kartikaya Gupta (email:[e-mail])]

In particular Lee wants 21f2946 for the add_raw_font API changes.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8860055 [details]
Bug 1357392 - Update IPC code for new fields in struct added in cb0bc28.

https://reviewboard.mozilla.org/r/132088/#review134882

Comment 18

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8860058 [details]
Bug 1357392 - Update calls to add_raw_font for API change in 21f2946.

https://reviewboard.mozilla.org/r/132094/#review134884

This one's fine for now. Lee has a patch to plumb things through properly that can go on top.

Comment 19

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8860052 [details]
Bug 1357392 - Update webrender to f3fa3481aac63ac93c6ccbe805379875e24e5b77.

https://reviewboard.mozilla.org/r/132082/#review134886

Comment 20

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8860053 [details]
Bug 1357392 - Update Cargo.lock/Cargo.toml files and re-generate FFI header.

https://reviewboard.mozilla.org/r/132084/#review134888

Comment 21

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8860054 [details]
Bug 1357392 - Re-vendor third-party rust dependencies.

https://reviewboard.mozilla.org/r/132086/#review134890

Comment 22

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8860056 [details]
Bug 1357392 - Update for removal of release callback function in 86d4255.

https://reviewboard.mozilla.org/r/132090/#review135124

Comment 23

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8860057 [details]
Bug 1357392 - Update callback functions for new parameter added in d733af2.

https://reviewboard.mozilla.org/r/132092/#review135126

::: gfx/webrender_bindings/src/bindings.rs:553
(Diff revision 1)
>  }
>  
>  impl ExternalImageHandler for WrExternalImageHandler {
>      fn lock(&mut self,
> -            id: ExternalImageId)
> +            id: ExternalImageId,
> +            _channel_index: u8)

Thanks, I will use the channel_index to select the correct data plane in yuv textureHost.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/2075cd677dc9
Update webrender to f3fa3481aac63ac93c6ccbe805379875e24e5b77. r=jrmuizel,jerry,lsalzman
https://hg.mozilla.org/projects/graphics/rev/ca9968f8bce5
Update IPC code for new fields in struct added in cb0bc28. r=kats

Comment 25

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/2075cd677dc9
https://hg.mozilla.org/mozilla-central/rev/ca9968f8bce5