Closed
Bug 1357582
Opened 7 years ago
Closed 7 years ago
Convert PRCList usage in PluginModuleParent to mozilla::LinkedList
Categories
(Core Graveyard :: Plug-ins, enhancement)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: erahm, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=c++] [good first bug])
We would like to update PRCList usage in nsPluginHost to use mozilla::LinkedList. - Convert |sModuleListHead| [1], to be a mozilla::LinkedList. - Update |PluginModuleMapping| [2] to inherit from mozilla::LinkedListElement - Update PRCList calls to LinkedList equivalents: - remove PR_INIT_CLIST - PR_INSERT_BEFORE -> LinkedList::insertBack - PR_INSERT_AFTER/PR_APPEND_LINK -> LinkedList::insertFront - remove PR_REMOVE_LINK - PR_CLIST_IS_EMPTY -> LinkedList::isEmpty - convert do/while loops w/ PR_LIST_HEAD/PR_NEXT_LINK -> range-based for (auto elm : list) [1] http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/dom/plugins/ipc/PluginModuleParent.cpp#354 [2] http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/dom/plugins/ipc/PluginModuleParent.cpp#216
Comment 1•7 years ago
|
||
(In reply to Eric Rahm [:erahm] from comment #0) > We would like to update PRCList usage in nsPluginHost to use > mozilla::LinkedList. > > - Convert |sModuleListHead| [1], to be a mozilla::LinkedList. > - Update |PluginModuleMapping| [2] to inherit from mozilla::LinkedListElement Be advised that this code is being removed in bug 1352575.
Comment 2•7 years ago
|
||
Let's not leave this bug here.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•