Closed Bug 1357915 Opened 7 years ago Closed 7 years ago

"Copy Download Link" not working in the Downloads View in the Library

Categories

(Firefox :: Bookmarks & History, defect, P1)

Product:
Firefox
Component:
Bookmarks & History
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 + verified
firefox56 - verified

People

(Reporter: grgoffe, Assigned: Paolo)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1357915 - Fix download commands operating on multiple items in the Library window.
59 bytes, text/x-review-board-request
standard8
: review+
jcristau
: approval-mozilla-beta+
Details 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170419100228

Steps to reproduce:

Start a download and then bring up the "download manager" where transfers are listed. Right click the download and select "copy download link". The URL should be in the copy/paste buffer but it is NOT.


Actual results:

see above


Expected results:

The procedure listed in #1 above should result in a copy of the URL in the copy/paste buffer.
Component: Untriaged → Downloads Panel
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
I tested this on Manjaro Linux (64-bit): I was unable to reproduce this behavior.
I verified this against the current stable (to check for regression) and the most current nightly.

Test Environment Information:
KDE Plasma Version: 5.9.4
KDE Framework Version: 5.33.0
Qt Version : 5.8.0
Kernel Version: 4.9.22-1-MANJARO

Firefox 52.0.2 (64-bit) Test Results:
Donwload Link 1 (PDF Document from Moodle): OK
Download Link 2 (firefox nightly): OK
Download Link 3 (wallpaper from thepaperwall): OK

55.0a1 (2017-04-22) (64-bit) Test Results:
Download Link 1 (PDF Document from Moodle): OK 
Download Link 2: (firefox nightly): OK
Download Link 3 (wallpaper from thepaperwall): OK

I did not test this against any other Desktop Environments or Clipboards. Perhaps this is a bug specific to a Desktop Environment (DE) or Windows Manager (WM)? What DE or WM was being used when this bug was experienced?
Flags: needinfo?(grgoffe)
I just tested with the latest FF Nightly. The problem still exists but not with the regular release. I haven't tested with the Beta release yet.

This is a Fedora 27 (rawhide) x86_64 system. 

Thanks,

George...
Flags: needinfo?(grgoffe)
More testing with FF Nightly, this time in safe-mode. Problem still exists.
Problem still exists with this "latest" FF Nightly.
Just tested with the Beta release... problem does NOT exist.
Priority: -- → P5
Same issue here on firefox 55b2 on Gnome/Linux.
Confirmed.
It works in 54. So this is a regression.
It works also on 55b1, so its a regression which happens in b2
Is this on Linux only? Has a developer taken a look yet?
Husam,

Yes, only Linux... Ihave NO windoze systems... :-)

I don't see any developers above here.

George...
Only three weeks till Firefox 55 release.
[Tracking Requested - why for this release]:
Regression from bug 1264206.
Assignee: nobody → paolo.mozmail
Blocks: 1264206
Status: UNCONFIRMED → ASSIGNED
tracking-firefox55: --- → ?
Component: Downloads Panel → Bookmarks & History
Ever confirmed: true
Keywords: regression
OS: Linux → All
Priority: P5 → P1
Hardware: x86_64 → All
Summary: Downloads manager select "copy download link" fails → "Copy Download Link" not working in the Downloads View in the Library
Comment on attachment 8887400 [details]
Bug 1357915 - Fix download commands operating on multiple items in the Library window.

https://reviewboard.mozilla.org/r/158264/#review163506

Thank you for fixing this. r=Standard8 so that we can get this landed & the regression fixed, though I really do think we should get a test written for this, as we're obviously missing coverage here.
Attachment #8887400 - Flags: review?(standard8) → review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5a32eeda51d
Fix download commands operating on multiple items in the Library window. r=Standard8
(In reply to Mark Banner (:standard8) from comment #15)
> Thank you for fixing this. r=Standard8 so that we can get this landed & the
> regression fixed, though I really do think we should get a test written for
> this, as we're obviously missing coverage here.

Thanks for the fast review. Unfortunately this view doesn't have test coverage at all, there is bug 1258195 on file for this.

I'm separating the data layer and at least adding tests for it in bug 1381411.
https://hg.mozilla.org/mozilla-central/rev/b5a32eeda51d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Please request Beta approval on this when you get a chance.
status-firefox54: --- → unaffected
status-firefox55: --- → affected
status-firefox-esr52: --- → unaffected
tracking-firefox56: --- → ?
Flags: needinfo?(paolo.mozmail)
Comment on attachment 8887400 [details]
Bug 1357915 - Fix download commands operating on multiple items in the Library window.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1264206
[User impact if declined]: Broken user interface
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet, only tested locally
[Needs manual test from QE? If yes, steps to reproduce]: Yes, per comment 0
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Fixes local code that was broken anyways
[String changes made/needed]: None
Flags: needinfo?(paolo.mozmail)
Attachment #8887400 - Flags: approval-mozilla-beta?
(In reply to :Paolo Amadini from comment #20)
> [Needs manual test from QE? If yes, steps to reproduce]: Yes, per comment 0

setting qe-verify+.
Flags: qe-verify+
Comment on attachment 8887400 [details]
Bug 1357915 - Fix download commands operating on multiple items in the Library window.

fix regression in downloads manager, beta55+
Attachment #8887400 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I could reproduce the issue on old nightly builds according to comment 0 on these:

------ affected nightly on windows ------
Version 	55.0a1
Build ID 	20170419030223
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

------ affected nightly on linux ------
Version 	55.0a1
Build ID 	20170419100228
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0



And the fix is hereby verified on :

------ latest DevEdition on windows ------
Version 	55.0b11
Build ID 	20170720101431
Update Channel 	aurora
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
OS 	        Windows_NT 6.1


------ latest DevEdition on linux ------
Version 	55.0b11
Build ID 	20170720171353
Update Channel 	aurora
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
OS 	        Linux 4.10.0-27-generic
Status: RESOLVED → VERIFIED
QA Whiteboard: [testday-20170721]
status-firefox55: fixed → verified
I have managed to reproduce the issue mentioned in comment 0 using Firefox 55.0a1 (BuildId:20170419100228).

This issue is verified fixed on Firefox 55.0b11 (BuildId:20170720171353) using Windows 10 64bit, Ubuntu 16.04 64bit and macOS 10.11.6.

This issue is also verified fixed on Firefox Nightly 56.0a1 (BuildId:20170723030206) using Windows 10 64 bit , Ubuntu 16.04 64 bit and macOS 10.11.6.
status-firefox56: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: