Closed Bug 1357988 Opened 7 years ago Closed 7 years ago

dom/media relies on ipc/chromium namespace pollution

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jbeich, Unassigned)

References

Details

Attachments

(1 file)

- OS_* are defined by ipc/chromium/chromium-config.mozbuild, if the pref moves this will break
- other code already uses MOZ_WIDGET_* or XP_*
- diverging from Linux parity on Tier3 platforms can increase bug triaging cost e.g., bug 1341108
FYI: media.rust.mp4parser=true works fine on FreeBSD 12 amd64.
Thanks for the correction!
Comment on attachment 8859835 [details]
Bug 1357988 - Don't use IPC macros for media pref defaults.

https://reviewboard.mozilla.org/r/131824/#review134686
Attachment #8859835 - Flags: review?(ayang) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6cd1cb7eaa9
Don't use IPC macros for media pref defaults. r=alfredo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e6cd1cb7eaa9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: