Closed
Bug 1358012
Opened 7 years ago
Closed 7 years ago
Permaorange test_bug877690.html | property float's values when Gecko 55 merges to beta on 2017-06-12
Categories
(DevTools :: Inspector: Rules, enhancement, P1)
Tracking
(firefox-esr45 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55+ fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | + | fixed |
People
(Reporter: philor, Unassigned)
References
Details
I must be missing something, since only bug 1156019 has touched it during the 55 cycle, and it doesn't seem to have touched anything to do with float, but https://treeherder.mozilla.org/logviewer.html#?job_id=92882784&repo=try (which you should be able to reproduce locally by just changing /config/milestone.txt from 55a1 to 55) says that test_bug877690.html is going to be permaorange when we merge to beta the next time. [Tracking Requested - why for this release]: Merge bustage, closed tree, delayed b1, sadness.
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(ttromey)
Comment 2•7 years ago
|
||
I thought we had a plan in place whereby the tests would be more lenient in situations like this. However, I don't really recall the details, so I'm forwarding this to Greg.
Flags: needinfo?(ttromey) → needinfo?(gtatum)
Comment 3•7 years ago
|
||
This is similar to the stuff I was doing with the static css database, but this appears to be a different test. I'm not sure the history on it. It's failing because float inline-end and float inline-start are both disabled on beta, but enabled on Aurora. The way I solved it was disabling on platforms that change, e.g. the test was only enabled on nightly. The only other option would be to make those two properties optional in the test.
Flags: needinfo?(gtatum)
Reporter | ||
Comment 5•7 years ago
|
||
Probably the easiest way to fix it, though, would be to ship float: inline-(start|end). Fixed by bug 1253919.
Status: NEW → RESOLVED
Closed: 7 years ago
Depends on: 1253919
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•