Closed
Bug 1358018
Opened 7 years ago
Closed 7 years ago
Make the second arg of insertRule optional
Categories
(Core :: DOM: CSS Object Model, enhancement)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
1.73 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
See https://www.w3.org/Bugs/Public/show_bug.cgi?id=27384 This applies to CSSStyleSheet and CSSGroupingRule. https://github.com/w3c/web-platform-tests/issues/5524 tracks adding tests for this.
|
Assignee | |
Comment 1•7 years ago
|
||
This tracks the spec change in https://www.w3.org/Bugs/Public/show_bug.cgi?id=27384
Attachment #8859879 -
Flags: review?(cam)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8859879 [details] [diff] [review] Make the second arg of CSSOM insertRule methods optional Review of attachment 8859879 [details] [diff] [review]: ----------------------------------------------------------------- Was going to ask if we need a test before the WPT ones arrive, but I suppose the general bindings layer tests for optional arguments should be sufficient.
Attachment #8859879 -
Flags: review?(cam) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a49b78b9fef5 Make the second arg of CSSOM insertRule methods optional. r=heycam
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a49b78b9fef5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•