1358128 - Intermittent LeakSanitizer | leak at Malloc, nsTArray_base, AppendElement, nsPipe::nsPipe

Status: RESOLVED WORKSFORME

(Core :: Networking: HTTP, defect)

Description

[Treeherder Bug Filer]

Filed by: cbook [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=92965625&repo=mozilla-central

https://queue.taskcluster.net/v1/task/NzNZ8Cw4S6CDWFmTrWrHzA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Carsten Book [:Tomcat]]

Andrew, do you know who could take a look at this leak (i guess this one is real)

Comment 2

[Andrew McCreight [:mccr8]]

I looked at the LSan log, and all of the leaks are indirect, except for one where the allocation happens here:
  mozilla::net::nsHttpTransaction::SetSecurityCallbacks(nsIInterfaceRequestor*) /home/worker/workspace/build/src/netwerk/protocol/http/nsHttpTransaction.cpp:511

Honza, do you know who might know about these security callbacks? Thanks.

Comment 3

[Honza Bambas (:mayhemer)]

Very hard to say.  Do we know which test can reproduce it?  Apparently under some conditions we don't release callbacks.  There was bug 1354220 recently filed and fixed, but that only fixes some omissions for the child part of the http channel.  We may miss a call to ReleaseListeners() somewhere in nsHttpChannel as well.

Comment 4

[Andrew McCreight [:mccr8]]

This hasn't been seen in the last week, so maybe it was fixed.

Comment 5

[Honza Bambas (:mayhemer)]

Aha!  the leak is from here:

https://dxr.mozilla.org/mozilla-central/rev/27311156637f9b5d4504373967e01c4241902ae7/netwerk/protocol/http/nsHttpTransaction.cpp#511

Looks like the dispatch fails.  Is this is a shutdown leak?

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Honza Bambas (:mayhemer) from comment #5)
> Looks like the dispatch fails.  Is this is a shutdown leak?

LeakSanitizer reports blocks of memory that are alive at shutdown, but not reachable from the stack.

Comment 7

[Intermittent Failures Robot]

3 failures in 831 pushes (0.004 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1
* mozilla-central: 1
* autoland: 1

Platform breakdown:
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1358128&startday=2018-02-26&endday=2018-03-04&tree=all

Comment 8

[Intermittent Failures Robot]

2 failures in 747 pushes (0.003 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 2

Platform breakdown:
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1358128&startday=2018-03-05&endday=2018-03-11&tree=all