Open Bug 1358163 Opened 7 years ago Updated 2 years ago

Intermittent GTest orange failing to copy a gmp-clearkey file

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement

Tracking

(firefox55 affected)

Tracking Flags:
Tracking Status
firefox55 --- affected

People

(Reporter: marco, Unassigned)

Details

I've seen this error a few times on code coverage builds.

An example: https://treeherder.mozilla.org/logviewer.html#?job_id=92779737&repo=mozilla-central&lineNumber=1606

The error is "ERROR - shutil error: Destination path '/home/worker/workspace/build/application/firefox/gmp-clearkey' already exists".

Could we avoid failing if the file already exists? Can we simply overwrite it?

I'm not sure if this is the right component.
Hey Joel, do you know who could look into this? For some reason it's pretty common in code coverage builds.
Flags: needinfo?(jmaher)
in this case that is just a regular error, not what is causing the job to turn orange, the later errors are the ones to worry about:
[task 2017-04-19T18:43:50.862612Z] 18:43:50     INFO -  TEST-START | ArenaAllocator.MemoryIsValid
[task 2017-04-19T18:43:50.997619Z] 18:43:50    ERROR -  gtest TEST-UNEXPECTED-FAIL | gtest | test failed with return code -134
[task 2017-04-19T18:43:51.042690Z] 18:43:51    ERROR - Return code: 1
[task 2017-04-19T18:43:51.043153Z] 18:43:51    ERROR - No tests run or test summary not found
[task 2017-04-19T18:43:51.043249Z] 18:43:51     INFO - TinderboxPrint: gtest-gtest<br/><em class="testfail">T-FAIL</em>
[task 2017-04-19T18:43:51.043479Z] 18:43:51    ERROR - # TBPL FAILURE #
[task 2017-04-19T18:43:51.043784Z] 18:43:51  WARNING - setting return code to 2
[task 2017-04-19T18:43:51.044030Z] 18:43:51    ERROR - The gtest suite: gtest ran with return status: FAILURE


this test is defined here:
https://dxr.mozilla.org/mozilla-central/source/xpcom/tests/gtest/TestArenaAllocator.cpp#151

based on a return code of 134, possibly this is a SIGABRT, maybe a failed assertion.


I see that :erahm authored this test, possibly he would have an idea of what to do here.
Flags: needinfo?(jmaher) → needinfo?(erahm)
I see a variety of failures for gtest on ccov builds, they all seem to be in the ArenaAllocator tests;  Possibly code coverage is interfering with this or chewing up more memory.
I ran into this `gmp-clearkey` thing a while ago, possibly while looking at some other failure in logs. It looks like at some point we started shipping gmp-clearkey with Firefox:
https://dxr.mozilla.org/mozilla-central/rev/abdcc8dfc28397b95338245390e12c56658ad182/browser/installer/package-manifest.in#812

Presumably that means we no longer need to install it via the test harness. I probably should have written this stuff down in a bug when I looked at it then. :) I think we put a copy of gmp-clearkey in the test package and it gets installed from there, so the fix would be to stop putting it in the test package.
bug 1353882 seems to be the root cause of the gtest failures, hopefully we can get all small things cleared up and running smoothly soon
Flags: needinfo?(erahm)
Product: Core → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.