1358287 - Stagefright-vs-Rust TrackInfo comparison is incorrect, leading to false reports

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

As per bug 1341483 comment 27:

Someone blog posted(http://blog.goo.ne.jp/atlanto/e/2cdc3c75132f7353c89e9eebc4f00a73):

the patch  attachment 8847073 [details] seems logically wrong.

https://dxr.mozilla.org/mozilla-central/source/media/libstagefright/binding/MP4Metadata.cpp#394

GetDifferentField(const mozilla::TrackInfo& info,
                  const mozilla::TrackInfo& infoRust)
{
  if (infoRust.mId != info.mId) { return "Id"; }
  if (infoRust.mKind == info.mKind) { return "Kind"; }
  ...


All most of "=="  seems typo, they should be "!=".
So, a lot of "Report Site Issue" notification pop up like a storm.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1358287 - Stagefright-vs-Rust TrackInfo comparison was incorrect -

Review commit: https://reviewboard.mozilla.org/r/132216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132216/

Comment 2

[Alfredo Yang (:alfredo)]

Comment on attachment 8860187 [details]
Bug 1358287 - Stagefright-vs-Rust TrackInfo comparison was incorrect -

https://reviewboard.mozilla.org/r/132216/#review135074

Comment 3

[Alfredo Yang (:alfredo)]

John, I think that's what we saw yesterday, a false alarm.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/801168366d99
Stagefright-vs-Rust TrackInfo comparison was incorrect - r=alfredo

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/801168366d99