1358611 - update releasetasks to support devedition betas

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P1)

Description

[[e-mail] (:bhearsum)]

At minimum we need to update https://github.com/mozilla/releasetasks/blob/master/releasetasks/templates/firefox/enUS.yml.tmpl#L157 to use nightly-signing and firefox-mozilla-aurora for the channel id.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

1. To begin with, hopefully I understood right the new approach. Since we're going to treat devedition as an entirely new product, I'd say the easiest way would be to just copy-paste [0] and create a new folder hierachy to serve for devedition  purposes. That way, we can give away potential if/else statements that we'd enrich the current firefox templates with.

2. I'm not sure I get this right, but if we want to use releasettasks templates, won't we need to add/mirror ['mozilla-beta'] configs from [1] in order to provide all the arguments that release runner needs, when instantinating the releasetasks templates? 

3. Code changes:

* https://github.com/mozilla/releasetasks/blob/master/releasetasks/templates/firefox/enUS.yml.tmpl#L157 to use nightly-signing and firefox-mozilla-aurora for the channel id. 
I think the same applies to https://github.com/mozilla/releasetasks/blob/master/releasetasks/templates/firefox/enUS.yml.tmpl#L293 as well. 

* the same for l10n here https://github.com/mozilla/releasetasks/blob/master/releasetasks/templates/firefox/l10n.yml.tmpl#L234 . 
I think the same applies to https://github.com/mozilla/releasetasks/blob/master/releasetasks/templates/firefox/l10n.yml.tmpl#L371 as well.

Could be some others as well. Depends on the configs we're feeding the templates with.

:bhearsum - should I go ahead and create the PR or should we take this sequentually? Ship-it, RR and see how that fits to releasetasks?
 
[0]: https://github.com/mozilla/releasetasks/tree/master/releasetasks/templates/firefox
[1]: http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py

Comment 2

[[e-mail] (:bhearsum)]

Rail probably has better thoughts on this than me, but I'll weigh in where I can now.

(In reply to Mihai Tabara [:mtabara]⌚️GMT+8 from comment #1)
> 1. To begin with, hopefully I understood right the new approach. Since we're
> going to treat devedition as an entirely new product, I'd say the easiest
> way would be to just copy-paste [0] and create a new folder hierachy to
> serve for devedition  purposes. That way, we can give away potential if/else
> statements that we'd enrich the current firefox templates with.

Rail was thinking we might be able to symlink, if we think we don't need to make any changes to the templates. Hopefully we can add support for configuring the things we need to configure rather than entirely forking?

> :bhearsum - should I go ahead and create the PR or should we take this
> sequentually? Ship-it, RR and see how that fits to releasetasks?

It might be worth a chat to make sure everyone is on the same page about the interfacing between them, but I don't think it makes sense to tackle one-by-one - we're already pressed for time on this, so we should do as much work in parallel as possible. Rail - I think you're planning to take on one or both of Ship It or releaserunner? If so, it sounds like you and Mihai should talk :)

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Ben Hearsum (:bhearsum) from comment #2)
> It might be worth a chat to make sure everyone is on the same page about the
> interfacing between them, but I don't think it makes sense to tackle
> one-by-one - we're already pressed for time on this, so we should do as much
> work in parallel as possible. Rail - I think you're planning to take on one
> or both of Ship It or releaserunner? If so, it sounds like you and Mihai
> should talk :)

Sounds good, thanks! I'll arrange with :rail for a quick chat today/tomorrow to get everyone on the same page.

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

So turns out we've gotten more solutions here:

1.
* parameterize ACCEPTED_CHANNEL_MAR and signing_class from release runner via releasetasks make graph
* rename firefox -> desktop and pass it explicitly via make_taskgraph from releasetasks 

2. symlink entire Firefox folder for the devedition bits to keep single-source for desktop part

3. copy-paste from firefox and adjust. Drawback here is we need to maintain both folders every time we need to fix something in releasetasks.

We'll move forward with 1). I'll tackle the work for both release runner + releastasks since they go hand in hand. We'll be setting soon a stage release on jamun that should help us catch all the paper cuts and missing bits that we currently have into place.

Note to self: we also need beetmover mozharness configs new templates for devedionn + and make sure the logic is generic enough

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1358611 - make signing_class and accepted mar channel id generic within releasetasks.

Questions/notes to self:
* is "dep-signing" used elsewhere but within the tests?
* I need to double check relpro client used on bm85 has the "project:releng:signing:cert:nightly-signing" scopes

@rail: can't remember, why did you want to rename the "firefox" folder to "desktop"? At this point I think most of the stuff within releasetasks is generic enough to handle DevEdition properly. Should I still account for that change?

WIP on tools side, incoming patches in a bit in bug 1358607.

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8865501 [details] [review]
Bug 1358611 - make signing_class and accepted mar channel id generic within releasetasks.

Refreshed the PR as per what we discussed yesterday.

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8865501 [details] [review]
Bug 1358611 - make signing_class and accepted mar channel id generic within releasetasks.

Refreshed PR with configurable templates directory coming via config.py. I renamed all the proper bits too. Sorry for the thrird turnaround here, hopefully, this is the last one :)

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8865501 [details] [review]
Bug 1358611 - make signing_class and accepted mar channel id generic within releasetasks.

https://github.com/mozilla/releasetasks/commit/379293b469d31252aaa4d405fefbc720c5748978

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1358611 - follow-up with bugfixes in releasetasks templates.

Fixing some rookie mistakes I've done.

Comment 10

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8868559 [details] [review]
Bug 1358611 - follow-up with bugfixes in releasetasks templates.

Approved by :rail in PR.
https://github.com/mozilla/releasetasks/commit/21ce74e75801f08ca8b1dc3de25e550d1e6e766e

Comment 11

[Mihai Tabara [:mtabara]⌚️GMT]

We now have a staging release scheduled on taskcluster, I think we can close this for now. 
Other fixing and follow-up stuff is tracked in bug 1364225.