Open Bug 1359018 Opened 7 years ago Updated 3 months ago

Image::SetHasError has callers that searchfox doesn't find

Categories

(Webtools :: Searchfox, enhancement)

Product:
Webtools
Component:
Searchfox
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
REOPENED

People

(Reporter: tnikkel, Unassigned)

References

(Depends on 1 open bug)

Details

DXR is no longer available. Searchfox is now replacing it.
See meta bug 1669906 & https://groups.google.com/g/mozilla.dev.platform/c/jDRjrq3l-CY for more details.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
Product: Webtools → Webtools Graveyard

This one still seems to be a problem with searchfox.

Status: RESOLVED → REOPENED
Component: DXR → Searchfox
Product: Webtools Graveyard → Webtools
Resolution: WONTFIX → ---
Summary: Image::SetHasError has callers that dxr doesn't find → Image::SetHasError has callers that searchfox doesn't find

Which callers is it missing?

From this search, I see two:
https://searchfox.org/mozilla-central/search?q=SetHasError&path=

Which are also here:
https://searchfox.org/mozilla-central/search?q=symbol:_ZN7mozilla5image13ImageResource11SetHasErrorEv%2C_ZN7mozilla5image5Image11SetHasErrorEv&redirect=false

The two results look to cover the same set of things.

Flags: needinfo?(tnikkel)

Ah, sorry. I didn't realize I clicked on the wrong one for my symbol search.

The use in BadImage looks like this:

template <typename T>
static already_AddRefed<Image> BadImage(const char* aMessage,
                                        RefPtr<T>& aImage) {
  aImage->SetHasError();
  return aImage.forget();
}

It is then instantiated with T=RasterImage and VectorImage so that's a bit of a weird case. I guess I could understand why that might be missed, because nothing really guarantees that because BadImage could be instantiated with two subclasses of Image that Image itself will work, although this specific location of course is always a call on Image.

The other use at mInnerImage->SetHasError() looks odder. You can even click on the SetHasError() to look for uses, and it doesn't show up in the results. So it clearly knows somewhere that that's Image::SetHasError. ImageWrapper doesn't even have any odd template stuff happening.

I wonder if the ImageWrapper issue might be that that line is both a use and a definition of the symbol? Though you'd think that would have shown up in other places.

Depends on: 1685188
Flags: needinfo?(babaopptech)
You need to log in before you can comment on or make changes to this bug.