Closed
Bug 1359140
Opened 7 years ago
Closed 7 years ago
Fix various ESLint issues in services/
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely. At the moment, services/ doesn't inherit rules from the mozilla/recommended configuration, and so just gets a basic set. In this patch, I'm running ESLint's autofix mechanism and then manually fixing some indentation. It is fixing rules like: - key-spacing - quotes (single -> double) - no-else-return - no-extra-semi - comma-spacing - object-shorthand There's still a few errors raised after that, but I'll leave those to a mentored bug to fix.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8861112 [details] Bug 1359140 - Fix various ESLint issues in services/ (mostly automatic). https://reviewboard.mozilla.org/r/133072/#review135872
Attachment #8861112 -
Flags: review?(markh) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d4ef1185bea Fix various ESLint issues in services/ (mostly automatic). r=markh
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5d4ef1185bea
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•