1359427 - Ignore gecko.log files from VCS

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

I occasionally add gecko.log as part of my patch, often when I’m fixing up patches in code review.  Adding it to .gitignore/.hgignore would solve that problem.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1359427 - Hide top-level gecko.log from VCSes;

gecko.log is generated by several test harnesses.  It sometimes gets added
as part of patches that are sent out for review.  By ignoring the file,
we can prevent it from being uploaded to mozreview.

Review commit: https://reviewboard.mozilla.org/r/133432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133432/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8861441 [details]
Bug 1359427 - Hide top-level gecko.log from VCSes;

https://reviewboard.mozilla.org/r/133432/#review136368

::: .hgignore:36
(Diff revision 1)
>  
>  # Build directories
>  ^obj
>  
> +# gecko.log is generated by various test harnesses
> +^gecko.log

The period needs escaped like elsewhere in this file.

I trust you can do this before landing.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8861441 [details]
Bug 1359427 - Hide top-level gecko.log from VCSes;

https://reviewboard.mozilla.org/r/133432/#review136368

> The period needs escaped like elsewhere in this file.
> 
> I trust you can do this before landing.

Well spotted, thanks!

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8861441 [details]
Bug 1359427 - Hide top-level gecko.log from VCSes;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133432/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2454031a4836
Hide top-level gecko.log from VCSes; r=gps

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2454031a4836

Comment 7

[Mike Hommey [:glandium]]

I'd argue we shouldn't write out a gecko.log in the source directory in the first place.