1359541 - Enable eslint on mobile/android/tests

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Geoff Brown [:gbrown]]

+++ This bug was initially created as a clone of Bug #1357557 +++

Comment 1

[Geoff Brown [:gbrown]]

Attachment: enable eslint on mobile/android/tests

I'm pretty sure I haven't broken any tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d5536a9fd5a79bbc2b30d22f1033cae7918c84c


:standard8 -- This is new ground for me; I'd appreciate lots of feedback.

:snorp -- Any concerns with linting mobile/android/tests?

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8861563 [details] [diff] [review]
enable eslint on mobile/android/tests

Review of attachment 8861563 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good. Please can you also remove the mobile/android/tests/.eslintrc file, as that isn't necessary (the various *-test configs define those for us).

::: mobile/android/tests/.eslintrc.js
@@ +1,5 @@
> +"use strict";
> +
> +module.exports = {
> +  "extends": [
> +    "plugin:mozilla/mochitest-test"

There's no simple mochitests in the test directory as far as I can tell, so you shouldn't need this file.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b4d43ed9b7f
Enable eslint on mobile/android/tests; r=standard8,snorp

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7b4d43ed9b7f