1359604 - Enable the ESLint recommended rules for taskcluster/docker/index-task/

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mark Banner (:standard8)]

I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely.

At the moment, taskcluster doesn't inherit rules from the mozilla/recommended configuration, and so just gets a basic set.

The aim of this bug is to get taskcluster/docker/index-task/ passing mozilla/recommended and for it to be enabled by default.

There's no other .js files in the taskcluster directory at the moment, so I'm not worried too much about enabling all of that directory, especially as index-task has the node environment.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1359604 - Enable the ESLint recommended rules for taskcluster/docker/index-task/.

Review commit: https://reviewboard.mozilla.org/r/133566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133566/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8861604 [details]
Bug 1359604 - Enable the ESLint recommended rules for taskcluster/docker/index-task/.

https://reviewboard.mozilla.org/r/133566/#review136502

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76156c1325d9
Enable the ESLint recommended rules for taskcluster/docker/index-task/. r=dustin

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/76156c1325d9