1359903 - convert equality assertions against PR_GetCurrentThread to use NS_ASSERT_OWNINGTHREAD instead

Status: NEW

(Core :: General, defect)

Description

[Nathan Froyd [:froydnj]]

The OWNINGTHREAD version is shorter and makes future changes to how owning thread assertions work much easier.

Undecided whether filing dependent bugs on this would be easier, or just doing all the work here would be easier.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Maybe we could just have a few sub-bugs by directory. The main directories that I see showing up are dom, netwerk, and xpcom. I'll file these tomorrow unless you get to it first.

I realized we also should do something about things like:
  MOZ_ASSERT(PR_GetCurrentThread() == gSocketThread);
Maybe we could just have a custom thing inside netwerk for that.

Comment 2

[Nathan Froyd [:froydnj]]

I have some patches for a few things in DOM.  While some are straightforward, some of them are definitely not. :(

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Nathan Froyd [:froydnj] from comment #2)
> I have some patches for a few things in DOM.  While some are
> straightforward, some of them are definitely not. :(

I could take care the one in dom/indexedDB and dom/filehandle if you haven't done it.

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Bevis Tseng[:bevis][:btseng] from comment #3)
> (In reply to Nathan Froyd [:froydnj] from comment #2)
> > I have some patches for a few things in DOM.  While some are
> > straightforward, some of them are definitely not. :(
> 
> I could take care the one in dom/indexedDB and dom/filehandle if you haven't
> done it.

That would be fantastic, thank you!