1360075 - Anonymous/XUL inspection: sometimes event listener popup shows wrong JavaScript code from bindings

Status: NEW

(DevTools :: Inspector, defect, P3)

Description

[684sigma]

I noticed an issue in Beta 53. It also happens in Nightly 55. Doesn't happen in Beta 52, ESR 45.
Sometimes event listener tooltips display wrong JavaScript code. Here's how to reproduce the bug:

1. Open https://www.w3schools.com/html/mov_bbb.mp4
2. Open inspector, click on event listener button near <video> tag.
3. Open 'canplay' event listener

Result: The code displayed in event listener tooltip is broken. The first line: 'function t---- > " + aEvent.type);'
Expected: The code should be normal

Comment 1

[684sigma]

Attachment: event listener shows wrong JavaScript code, by reporter.zip

1. Create pref dom.allow_XUL_XBL_for_file as true.
2. Open attached .html page
3. Open inspector, click on event listener button near <test> tag
4. Open 'click' event handler

Result: The code displayed in event listener tooltip is broken. This is how it looks in Nightly 55
    function efault(); // long comment long comment long comment
    });
    console.log('constructo

Expected: The code should be normal
    function(event) {
      event.preventDefault(); // long comment long comment long comment
    }

Comment 2

[Mike Taylor [:miketaylr]]

Gabriel, should this block the 55 release?

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Mike, can you assist here? I don't think this should be a 55 release blocker, but I need the final judgement up to you as well.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

100% not a blocker... I will add it to my todo list though as I plan on looking into using sourcemaps for React code in these popups anyhow.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

To be clear, some listeners are displayed worse and some better but on the whole it is improved.

It obviously needs more work though.

Comment 6

[Mike Taylor [:miketaylr]]

Thanks Mike, Gabriel -- I'll mark as fix-optional for 55.

Comment 7

[Patrick Brosset <:pbro>]

DevTools bug triage (filter on CLIMBING SHOES).

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on HOTFROG.