Closed
Bug 1360403
Opened 7 years ago
Closed 7 years ago
Remove hackarounds in test_keyframes_vendor_prefix.html
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(1 file)
We added a dummy rule in tests in test_keyframes_vendor_prefix.html to avoid single insertRule call problem. Now the problem has been solved in bug 1336863. We can drop the dummy rule. https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5b2432391ec2f5c469244b06934485e07c042c7
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8862692 [details] Bug 1360403 - Remove no-longer-needed hackarounds for now-fixed insertRule problem on stylo. https://reviewboard.mozilla.org/r/134560/#review137744 ::: commit-message-2cca3:1 (Diff revision 2) > +Bug 1360403 - Remove hackarounds for insertRule problem on stylo. r?dholbert Commit message tweak, to be slightly clearer: s/hackarounds/no-longer-needed hackarounds/ ...or: s/for insertRule problem/for now-fixed insertRule problem/ ...or something like that, to make it clear that the problem is addressed and that's why we're removing the hackarounds.
Attachment #8862692 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #3) > Comment on attachment 8862692 [details] > Bug 1360403 - Remove hackarounds for insertRule problem on stylo. > > https://reviewboard.mozilla.org/r/134560/#review137744 > > ::: commit-message-2cca3:1 > (Diff revision 2) > > +Bug 1360403 - Remove hackarounds for insertRule problem on stylo. r?dholbert > > Commit message tweak, to be slightly clearer: > s/hackarounds/no-longer-needed hackarounds/ > > ...or: > s/for insertRule problem/for now-fixed insertRule problem/ > > ...or something like that, to make it clear that the problem is addressed > and that's why we're removing the hackarounds. Indeed! Thank you!
Comment hidden (mozreview-request) |
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/684c9e3c2540 Remove no-longer-needed hackarounds for now-fixed insertRule problem on stylo. r=dholbert
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/684c9e3c2540
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•