Open
Bug 1361079
Opened 7 years ago
Updated 2 months ago
Add option to open Browser Toolbox from non-browser windows
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: isaacschemm, Assigned: isaacschemm)
Details
Attachments
(1 file, 3 obsolete files)
17.75 KB,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49 Build ID: 20170410193223 Steps to reproduce: * Opened browser and composer windows. * Opened Browser Toolbox from Tools > Web Development in a browser window, then immediately closed the browser window so only the composer window was open. Actual results: * Browser Toolbox opened using the composer window's environment, allowing me to debug an add-on. Expected results: It would be nice to be able to open the Browser Toolbox from non-browser windows (as long as remote debugging is turned on.) Ideally, it should load using the window you opened it from, but this isn't the case even now.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
This patch adds Browser Console and Browser Toolbox menu items to the Web Development submenu across all SeaMonkey windows, but if the window is a browser window, they are hidden in favor of the ones in webDeveloperOverlay. I thought this might be the best way to add the items to other windows without breaking anything in browser windows. Keyboard shortcuts are Ctrl+Shift+J for Browser Console and Ctrl+Shift+Alt+I for Browser Toolbox.
Attachment #8866554 -
Flags: feedback?(iann_bugzilla)
Attachment #8866554 -
Flags: feedback?(frgrahl)
Comment 3•7 years ago
|
||
Isaac sorry. I will see that I can try it out this weekend. Was a little busy with breakages during the last one. The patch contains l10n changes so the first release where this could go in is 2.52a1 right now.
Assignee: nobody → isaacschemm
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•7 years ago
|
Version: SeaMonkey 2.49 Branch → Trunk
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Frank-Rainer Grahl from comment #3) > Isaac sorry. I will see that I can try it out this weekend. Was a little > busy with breakages during the last one. It wasn't ready for review yet anyway, so no worries. > The patch contains l10n changes so the first release where this could go in > is 2.52a1 right now. Sounds good to me.
Version: Trunk → SeaMonkey 2.49 Branch
Comment on attachment 8866554 [details] [diff] [review] 1361079-devtools-in-other-windows.patch >+++ b/suite/locales/en-US/chrome/common/tasksOverlay.dtd >+ >+<!ENTITY browserConsoleCmd.label "Browser Console"> >+<!ENTITY browserConsoleCmd.accesskey "B"> >+<!ENTITY browserConsoleCmd.commandkey "Q"> >+ >+<!-- LOCALIZATION NOTE (browserToolboxMenu.label): This is the label for the >+ - application menu item that opens the browser toolbox UI in the Tools menu >+ - for non-browser windows. --> >+<!ENTITY browserToolboxMenu.label "Browser Toolbox"> >+<!ENTITY browserToolboxMenu.accesskey "e"> >+<!ENTITY browserToolboxCmd.commandkey "Q"> Stick to the commandkey that was used in webDeveloper.dtd You will need include the removal parts from the first patch so far so good so f+
Attachment #8866554 -
Flags: feedback?(iann_bugzilla) → feedback+
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Ian Neal from comment #5) > Comment on attachment 8866554 [details] [diff] [review] > 1361079-devtools-in-other-windows.patch > > >+++ b/suite/locales/en-US/chrome/common/tasksOverlay.dtd > >+ > >+<!ENTITY browserConsoleCmd.label "Browser Console"> > >+<!ENTITY browserConsoleCmd.accesskey "B"> > >+<!ENTITY browserConsoleCmd.commandkey "Q"> > >+ > >+<!-- LOCALIZATION NOTE (browserToolboxMenu.label): This is the label for the > >+ - application menu item that opens the browser toolbox UI in the Tools menu > >+ - for non-browser windows. --> > >+<!ENTITY browserToolboxMenu.label "Browser Toolbox"> > >+<!ENTITY browserToolboxMenu.accesskey "e"> > >+<!ENTITY browserToolboxCmd.commandkey "Q"> > > Stick to the commandkey that was used in webDeveloper.dtd Will do. That was a change for testing I forgot to back out. > > You will need include the removal parts from the first patch > > so far so good so f+ In this patch, the buttons in tasksOverlay get hidden in the browser window, where the ones from webDeveloper are used instead. But I think I might go back to doing it the other way.
Assignee | ||
Comment 7•7 years ago
|
||
Version 2 of patch: fixed keyboard shortcuts and removed Browser Console and Browser Toolbox from webDeveloper files
Attachment #8863935 -
Attachment is obsolete: true
Attachment #8866554 -
Attachment is obsolete: true
Attachment #8866554 -
Flags: feedback?(frgrahl)
Attachment #8870186 -
Flags: feedback?(iann_bugzilla)
Comment hidden (spam) |
Updated•2 months ago
|
Attachment #9385358 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•