Closed
Bug 1361151
Opened 7 years ago
Closed 7 years ago
Bugzilla Security groups are periodically synced to Phabricator project membership
Categories
(bugzilla.mozilla.org :: Phabricator Integration, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dkl, Assigned: dkl)
References
()
Details
Attachments
(1 file)
11.94 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
**AC** - cli wrapper that executes the sync function once given a phabricator and bugzilla - can run from demo - code is in a docker or similar container that will be deployed later - deployment not solved
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
This will be ran from a cron script in the BMO infrastructure periodically (maybe every 15mins?). It will be updating project members in Phabricator to match a defined list of security groups in BMO. dkl
Attachment #8869455 -
Flags: review?(dylan)
Comment 2•7 years ago
|
||
Comment on attachment 8869455 [details] [diff] [review] 1361151_1.patch Review of attachment 8869455 [details] [diff] [review]: ----------------------------------------------------------------- r+ but fix on commit. ::: extensions/PhabBugz/bin/update_project_members.pl @@ +48,5 @@ > +# 4. Set project members to exact list > +# 5. Profit > + > +$phab_sync_groups = [ split('[,\s]+', $phab_sync_groups) ]; > +my $sync_groups = Bugzilla::Group->match({ name => $phab_sync_groups }); use regex quoting, and also I don't like reusing variables with different types in them. This can be an array and passed by reference to match(). my @phab_sync_groups = split(/[,\s+]/, $phab_sync_groups); my $sync_groups = Bugzilla::Group->match({ name => \@phab_sync_groups }); @@ +74,5 @@ > + my ($group) = @_; > + my $group_obj = ref $group ? $group : Bugzilla::Group->check({ name => $group }); > + my $members_all = $group_obj->members_complete(); > + my %users; > + foreach my $name (sort keys %$members_all) { sort is surely not required here?
Attachment #8869455 -
Flags: review?(dylan) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks To https://github.com/mozilla-bteam/bmo.git d7e7c68..44cef9c master -> master will file a new bug for all of the new breakage due to change to t/Support/Files.pm dkl
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Component: General → Extensions: PhabBugz
Product: Conduit → bugzilla.mozilla.org
Version: unspecified → Production
You need to log in
before you can comment on or make changes to this bug.
Description
•