1361208 - Update Firefox Screenshots to version 6.6.0

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

This bug updates the version of Firefox Screenshots in the tree from 5.5.0 to 6.6.0.

r? Standard8 to see if I've managed to push the patch to this bug correctly.

Changelog: https://github.com/mozilla-services/screenshots/blob/master/CHANGELOG.md#version-660

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree;

Review commit: https://reviewboard.mozilla.org/r/135306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135306/

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Whoops, comment 0 should say we're going from version 6.3.0 to 6.6.0.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Pushed manually to Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62e221d278cf0cf87882e3cf169ec9abce5a64c3

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8863536 [details]
Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree;

https://reviewboard.mozilla.org/r/135306/#review138478

This looks fine. The only thing I'd say is it might be worth documenting in the screenshots repo the export process.

Since I'm fairly sure you haven't got level 3 access, I'll push this to autoland for you now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/525326d5ddb1
import latest version of Screenshots (6.6.0) into the tree; r=standard8

Comment 6

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Comment on attachment 8863536 [details]
Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree;

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 1356243. This will block us from enabling on Beta if it is not uplifted.

[User impact if declined]:
We will not be able to test Screenshots in Beta.

[Is this code covered by automated tests?]:
Yes.

[Has the fix been verified in Nightly?]:
Not yet.


[Needs manual test from QE? If yes, steps to reproduce]: 
No.

[List of other uplifts needed for the feature/fix]:
This is it.

[Is the change risky?][Why is the change risky/not risky?]::
Moderately. In addition to the test fix, it includes some small style fixes.

[String changes made/needed]:
None

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/525326d5ddb1

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8863536 [details]
Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree;

In order to test Screenshots in Beta54. Beta54+. Should be in 54 beta 5.

Comment 9

[Carsten Book [:Tomcat]]

needs rebasing for beta like grafting 415112:525326d5ddb1 "Bug 1361208 - import latest version of Screenshots (6.6.0) into the tree; r=standard8"
merging browser/extensions/screenshots/bootstrap.js
warning: conflicts while merging browser/extensions/screenshots/bootstrap.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/94d16b8d4a52

Comment 11

[Andrei Vaida [:avaida]]

(In reply to Cory Price [:ckprice] from comment #6)
> [Is this code covered by automated tests?]:
> Yes.
> 
> [Has the fix been verified in Nightly?]:
> Not yet.
> 
> [Needs manual test from QE? If yes, steps to reproduce]: 
> No.

Setting qe-verify- based on Cory's assessment on manual testing needs and the fact that this fix has automated coverage.