Closed
Bug 1361429
Opened 7 years ago
Closed 7 years ago
Only render filter bar when relevant props have changed
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox55 fixed)
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
(Whiteboard: [console-html])
Attachments
(2 files)
Right now we are re-rendering the FilterBar and children on every change
|
||
Updated•7 years ago
|
Flags: qe-verify?
Priority: -- → P2
|
Assignee | |
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: P2 → P1
|
|
||
Updated•7 years ago
|
Iteration: --- → 55.5 - May 15
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8863821 [details] Bug 1361429 - Grab only the filterBarVisible property to limit number of re-renders for FilterBar; https://reviewboard.mozilla.org/r/135564/#review138746
Attachment #8863821 -
Flags: review?(nchevobbe) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8863822 [details] Bug 1361429 - Convert FilterButton to functional component; https://reviewboard.mozilla.org/r/135566/#review138748 Could you remove the `createFactory` call here http://searchfox.org/mozilla-central/source/devtools/client/webconsole/new-console-output/components/filter-bar.js#25 ? We shouldn't need it
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 7•7 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4) > Comment on attachment 8863822 [details] > Bug 1361429 - Convert FilterButton to functional component; > > https://reviewboard.mozilla.org/r/135566/#review138748 > > Could you remove the `createFactory` call here > http://searchfox.org/mozilla-central/source/devtools/client/webconsole/new- > console-output/components/filter-bar.js#25 ? We shouldn't need it Done, good catch
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8863822 [details] Bug 1361429 - Convert FilterButton to functional component; https://reviewboard.mozilla.org/r/135566/#review138878
Attachment #8863822 -
Flags: review?(nchevobbe) → review+
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ce30397e7d2 Grab only the filterBarVisible property to limit number of re-renders for FilterBar;r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/6a08f464248c Convert FilterButton to functional component;r=nchevobbe
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2ce30397e7d2 https://hg.mozilla.org/mozilla-central/rev/6a08f464248c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•