Closed Bug 1361574 Opened 7 years ago Closed 7 years ago

Apple Live Photos flicker to black

Categories

(Core :: Graphics: Canvas2D, defect, P1)

50 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- wontfix
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: jagger27.com, Assigned: kechen)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170413192749

Steps to reproduce:

On https://developer.apple.com/live-photos/ the Live Photos don't play properly.

macOS Sierra 10.12.4, MacBook Pro 13" (Late 2013)


Actual results:

The embedded videos flicker/fade to black


Expected results:

Video should play smoothly.
Screen capture of issue: https://youtu.be/XedbKrPYPO8
Component: Untriaged → Graphics
Product: Firefox → Core
I can reproduce it on my MBP.
Status: UNCONFIRMED → NEW
Component: Graphics → Canvas: 2D
Ever confirmed: true
I was able to reproduce it. A simplified testcase would be helpful here.
Bisected it to bug 1289380.
Blocks: 1289380
Flags: needinfo?(nical.bugzilla)
I have not been able to reproduce this with the computers I have handy (none of which are macs), even with skia-gl canvas and gl layers enabled. Ethan, could you have a look?
Flags: needinfo?(nical.bugzilla) → needinfo?(ethlin)
(In reply to Nicolas Silva [:nical] from comment #5)
> I have not been able to reproduce this with the computers I have handy (none
> of which are macs), even with skia-gl canvas and gl layers enabled. Ethan,
> could you have a look?

Okay, I will look into this recently. I'll see how to create a simple testcase.
Flags: needinfo?(ethlin)
Keywords: regression
Priority: -- → P1
Whiteboard: [gfx-noted]
Keep the ni? to myself.
Flags: needinfo?(ethlin)
This page uses a Javascript API called LivePhotosKit.
Looks like it creates several canvas elements in the same position and rotates the elements with z-index.

There is a simple test case that uses the API[1].

[1] https://people-mozilla.org/~kechen/LivePhotosKitTest.html
Kevin will look into this issue. Set him as the assignee.
Assignee: nobody → kechen
Flags: needinfo?(ethlin)
Disable gfx.canvas.azure.accelerated can fix the bug.
Still trying to analysis the behavior of LivePhotosKit API.
Comment on attachment 8871226 [details]
Bug 1361574 - Restore texture after creating the video texture;

https://reviewboard.mozilla.org/r/142722/#review150014
Attachment #8871226 - Flags: review?(sotaro.ikeda.g) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fc110df7b526
Restore texture after creating the video texture; r=sotaro
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fc110df7b526
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
This is too late for 54 at this point, but it is it severe enough that you think we should consider it for ESR52 backport still? Or can it just ride the 55 train?
Flags: needinfo?(kechen)
Version: 53 Branch → 50 Branch
Looks like Apple already fixed this problem from their API side, the flicker problem from comment 0 doesn't exist in every firfox channel anymore.
Therefore, in my opinion, as long as there are not no other issues affected by this bug, it is okay to let it stay in 55.
Flags: needinfo?(kechen)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: