Closed
Bug 1361835
Opened 7 years ago
Closed 7 years ago
Perfherder numbers could be formatted better
Categories
(Tree Management :: Perfherder, enhancement)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
References
Details
Attachments
(1 file)
Very large numbers could be formatted to be more readable in Perfherder. I.e. instead of: 211515317.54 We should show something like: 211,515,317.54 This is quite easy to do with angular's number filter: https://docs.angularjs.org/api/ng/filter/number The only problem is that by default it shows 3 digits of precision with decimal values which is more than what we want. Let's override that behaviour, but otherwise use it as-is.
|
||
Comment 1•7 years ago
|
||
|
Assignee | |
Updated•7 years ago
|
Attachment #8864289 -
Flags: review?(rwood)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8864289 [details] [review] [treeherder] wlach:1361835 > mozilla:master Awesome, LGTM
Attachment #8864289 -
Flags: review?(rwood) → review+
|
||
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/1c75b3b27bb6088377e684f88642dfa7fe444899 Bug 1361835 - More readable number formatting in perfherder (#2446)
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•