Closed
Bug 1362003
Opened 7 years ago
Closed 7 years ago
nsGlobalWindow::GetLocation doesn't need to receive an ErrorResult param
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 1 obsolete file)
|
12.86 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Would be nice to get rid of nsIDOMLocation completely. Maybe as follow up.
Assignee: nobody → amarchesini
Attachment #8864480 -
Flags: review?(bzbarsky)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8864480 [details] [diff] [review] location2.patch >+ [PutForwards=href, Unforgeable, BinaryName="getLocation", Why the BinaryName instead of just renaming the getter to Location() on the C++ side?
Attachment #8864480 -
Flags: review?(bzbarsky) → review-
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8864480 -
Attachment is obsolete: true
Attachment #8864814 -
Flags: review?(bzbarsky)
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8864814 [details] [diff] [review] location2.patch After this, the only consumers of nsIDOMLocation are devtools/server/actors/object.js and nsIDOMDocument bits, right? Do you mind filing a followup to either remove nsIDOMLocation altogether or at least make it an empty interface? r=me
Attachment #8864814 -
Flags: review?(bzbarsky) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2bc7a6959b nsGlobalWindow::GetLocation doesn't need to receive an ErrorResult param, r=bz
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9e2bc7a6959b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•