1362164 - Clean up mozharness ccache code

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

mozharness has code related to ccache. It can be cleaned up (likely deleted) in an sccache world.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1362164 - Remove mozharness code to print ccache stats;

I was going to inline "enable_ccache" into buildbase.py because AFAICT
its value is effectively "if not windows." However, I realized that
all this is doing is dumping ccache stats (something the build system
itself is in a better position to do because it actually knows if
ccache is enabled). Then I realized we don't use ccache directly
any more in automation because we use sccache (or at least that's the
way it should be).

Since there's no need for this ccache code in mozharness, this commit
deletes it. If we want it back, we can add the functionality to
`mach build`.

Review commit: https://reviewboard.mozilla.org/r/136310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136310/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8864633 [details]
Bug 1362164 - Remove mozharness code to print ccache stats;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136310/diff/1-2/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8864633 [details]
Bug 1362164 - Remove mozharness code to print ccache stats;

https://reviewboard.mozilla.org/r/136310/#review141760

I think we might still be using ccache in a few weirdo build types, but we don't care about the stats in any event.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 37264210b0ee -d 508966268fab: rebasing 395249:37264210b0ee "Bug 1362164 - Remove mozharness code for print ccache stats; r=ted" (tip)
merging testing/mozharness/configs/builds/releng_base_android_64_builds.py
merging testing/mozharness/configs/builds/releng_base_linux_32_builds.py
merging testing/mozharness/configs/builds/releng_base_linux_64_builds.py
merging testing/mozharness/configs/builds/releng_base_mac_64_builds.py
merging testing/mozharness/configs/builds/releng_base_mac_64_cross_builds.py
merging testing/mozharness/configs/builds/releng_base_windows_32_builds.py
merging testing/mozharness/configs/builds/releng_base_windows_64_builds.py
merging testing/mozharness/configs/builds/releng_sub_linux_configs/32_artifact.py
merging testing/mozharness/configs/builds/releng_sub_linux_configs/32_debug_artifact.py
merging testing/mozharness/configs/builds/releng_sub_linux_configs/64_artifact.py
merging testing/mozharness/configs/builds/releng_sub_linux_configs/64_debug_artifact.py
merging testing/mozharness/configs/builds/releng_sub_linux_configs/64_stat_and_debug.py
merging testing/mozharness/configs/builds/releng_sub_linux_configs/64_stat_and_opt.py
merging testing/mozharness/configs/builds/releng_sub_mac_configs/64_artifact.py
merging testing/mozharness/configs/builds/releng_sub_mac_configs/64_debug_artifact.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win32_clang.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win32_clang_debug.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win32_qr_debug.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win32_qr_opt.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win64_asan_debug.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win64_asan_opt.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win64_clang.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win64_clang_debug.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win64_qr_debug.py
merging testing/mozharness/configs/builds/taskcluster_firefox_win64_qr_opt.py
merging testing/mozharness/configs/builds/taskcluster_firefox_windows_32_addondevel.py
merging testing/mozharness/configs/builds/taskcluster_firefox_windows_32_debug.py
merging testing/mozharness/configs/builds/taskcluster_firefox_windows_32_opt.py
merging testing/mozharness/configs/builds/taskcluster_firefox_windows_64_addondevel.py
merging testing/mozharness/configs/builds/taskcluster_firefox_windows_64_debug.py
merging testing/mozharness/configs/builds/taskcluster_firefox_windows_64_opt.py
merging testing/mozharness/mozharness/mozilla/building/buildbase.py
warning: conflicts while merging testing/mozharness/mozharness/mozilla/building/buildbase.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8864633 [details]
Bug 1362164 - Remove mozharness code to print ccache stats;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136310/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e04c49d2d10
Remove mozharness code to print ccache stats; r=ted

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e04c49d2d10

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out because it blocked the backout of bug 1362148.

https://hg.mozilla.org/mozilla-central/rev/99a21fe69212659a5d5c587b0886e2d2208e1e8f

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8864633 [details]
Bug 1362164 - Remove mozharness code to print ccache stats;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136310/diff/3-4/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88db54eae40a
Remove mozharness code to print ccache stats; r=ted

Comment 11

[Gregory Szorc [:gps]]

I rebased this to before the patches in bug 1362148 and re-landed it, since I had to write new code for bug 1362148 and I don't like good patches sitting around.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/88db54eae40a