Closed
Bug 1362245
Opened 7 years ago
Closed 7 years ago
Stop running commands during recording for BlobImage
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file, 1 obsolete file)
|
24.94 KB,
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
Currently, DrawTargetRecording runs all of the commands that it's recording while recording. We need to not do this.
|
Assignee | |
Comment 1•7 years ago
|
||
One impediment to fixing this now is that SourceSurfacesRecording wrap a real SourceSurface. If you call GetDataSurface() on it, it calls the real SourceSurface's GetDataSurface(). The plan is to make GetDataSurface() return nullptr on SourceSurfaceRecording and then not call GetDataSurface() while painting.
|
||
Updated•7 years ago
|
Whiteboard: [gfx-noted]
|
|
Assignee | |
Comment 2•7 years ago
|
||
Assignee: nobody → jmuizelaar
Blocks: omtp
|
|
Assignee | |
Comment 3•7 years ago
|
||
I have this split up in a bunch of pieces if you'd prefer to review it that way, but it shouldn't be too bad to review all at once.
Attachment #8875008 -
Attachment is obsolete: true
Attachment #8876740 -
Flags: review?(lsalzman)
|
|
Assignee | |
Comment 4•7 years ago
|
||
Comment on attachment 8876740 [details] [diff] [review] patch Review of attachment 8876740 [details] [diff] [review]: ----------------------------------------------------------------- This keeps around mFinalDT but mostly doesn't use it (except for when creating a PathBuilder). All playback is ripped out and we'll no longer hold references to things to mFinalDT::GraidentStops or SourceSurfaces etc.
|
||
Updated•7 years ago
|
Attachment #8876740 -
Flags: review?(lsalzman) → review+
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fc0a10e36093 Stop running commands during recording for BlobImage. r=lsalzman
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc0a10e36093
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•